-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring up Android device aot on ci #50510
Closed
Closed
Changes from 56 commits
Commits
Show all changes
75 commits
Select commit
Hold shift + click to select a range
33a7a32
Bring up Android device aot on ci
0d8ff94
Merge remote-tracking branch 'upstream/main' into enable-droid-device…
01adef8
Bump the aot timeout to see how long it really takes
450fe1e
See if trimming helps w/ the build time
fa5d814
Merge remote-tracking branch 'upstream/main' into enable-droid-device…
4409b89
Raise the default number of trampolines
3a097ec
Mirroring wasm skips for aot and trimming
639fcf0
Skip more suites that fail aot
eed28b9
Merge remote-tracking branch 'upstream/main' into enable-droid-device…
490f7c5
More exclusions.
31f4555
More exclusions
8d9ad90
See if default trimming produces better results
eb11e93
Make sure to skip problematic tests
cb132d1
More skips
9f5991c
Trimming switch so the other builds don't fail
9baa874
Skip the tests failing due to 'Attempting to JIT compile method while…
MaximLipnin c2d528f
Merge branch 'main' into enable-droid-device-aot
MaximLipnin 5887106
Remove redundant attribute
MaximLipnin 6a7b42c
Merge branch 'main' into enable-droid-device-aot
MaximLipnin 6bfe553
Skip more library tests due to "Attempting to JIT compile method ... …
MaximLipnin 3669c17
Fix wrong attribute
MaximLipnin 27e6fe0
Add System using
MaximLipnin ed1dc03
Merge branch 'main' into enable-droid-device-aot
MaximLipnin e680218
Skip more library tests due to "Attempting to JIT compile method ... …
MaximLipnin 7635795
Avoid some test failures related to DebuggerSupport
MaximLipnin dad7cab
Skip a test failing with NRE
MaximLipnin b3ceed5
Move ConditionalClass up to the right level
db00361
More skipped tests
MaximLipnin de9fe15
Merge branch 'main' into enable-droid-device-aot
MaximLipnin 3a96c05
Merge branch 'enable-droid-device-aot' of https://github.com/steveiso…
MaximLipnin 4f498b7
More skipped library tests
MaximLipnin 42e7658
Merge branch 'main' into enable-droid-device-aot
MaximLipnin ff94a36
Skip more tests
MaximLipnin 64784c4
Merge branch 'main' into enable-droid-device-aot
MaximLipnin 386d365
Skip more tests
MaximLipnin 1ac9b88
Skip more tests
MaximLipnin 14f9ab0
Merge branch 'main' into enable-droid-device-aot
MaximLipnin f692894
Skip more tests
MaximLipnin 27452e9
Skip more tests
MaximLipnin d11612f
Merge branch 'main' into enable-droid-device-aot
MaximLipnin 5620351
Remove an active issue attribute since nimt-trampolines parameter has…
MaximLipnin 846d697
Skip more tests
MaximLipnin 075052e
Skip yet another test suite perhaps due to infra issue
MaximLipnin 88de22f
Merge branch 'main' into enable-droid-device-aot
MaximLipnin d14d51e
Add active issue links
MaximLipnin 6a9a4cd
Merge branch 'main' into enable-droid-device-aot
MaximLipnin 5870d41
Try re-enabling some test suites which previously had no CI results
MaximLipnin e6a9602
Add an active issue
MaximLipnin 54e6bae
Add XUnit using to enable ActiveIssue attribute
MaximLipnin 1713dc3
Merge branch 'main' into enable-droid-device-aot
MaximLipnin 33d7684
Merge branch 'main' into enable-droid-device-aot
MaximLipnin d7eca0b
Merge branch 'main' into enable-droid-device-aot
MaximLipnin 376bdb4
Add '$(RunDisabledAndroidTests)' != 'true'
MaximLipnin 1a6e99f
Add an active issue to the disabled test suites
MaximLipnin e5b2dab
Try re-using EnableAggressiveTrimming
MaximLipnin c684fc3
Update tests.proj
MaximLipnin 171d528
Merge branch 'main' into enable-droid-device-aot
MaximLipnin a7fbfeb
Merge branch 'main' into enable-droid-device-aot
MaximLipnin 8697a56
Use tvOS in PlatformDetection.IsNotDeviceAOT
MaximLipnin 4ecdf5b
Exclude Microsoft.Extensions.DependencyModel.Tests test suite
MaximLipnin 874e9c7
Exclude Microsoft.NETCore.Platforms.BuildTasks.Tests.GenerateRuntimeG…
MaximLipnin db088de
Using
MaximLipnin 72389de
Enable debugger support
MaximLipnin 2933ae8
More debugger support
MaximLipnin c1ab593
Same issue as on browser
MaximLipnin cfb2051
Method is not supported
MaximLipnin d481664
Merge branch 'main' into enable-droid-device-aot
MaximLipnin 0600168
Bump ngsharedvt-trampolines value up to 8800 ?
MaximLipnin 3755d74
Merge remote-tracking branch 'upstream/main' into enable-droid-device…
10e2e48
Flip back llvm flag
41f8319
Merge remote-tracking branch 'upstream/main' into enable-droid-device…
e26477a
quick fix
6f33cb9
Merge branch 'main' into enable-droid-device-aot
MaximLipnin b52642d
Merge branch 'main' into enable-droid-device-aot
MaximLipnin 2cefff0
Re-enable System.Linq.Expressions.Tests test suite to see any failures
MaximLipnin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we expect this to include tvOS and MacCatalyst ? Is Device specifically Android and iOS (excluding tvOS MacCatalyst)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure, no issue to include them here or it can be done in a follow-up @steveisok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think naming-wise,
IsNotDeviceAOT
may suggest the platform isnot AOT compiled iOS, Android, or tvOS
, but in this PR, it'snot AOT compiled iOS or Android
. I'm curious if we intend to skip the same test methods if on AOT tvOS (if we plan to have AOT tvOS).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to be consistent with naming, I can add
tvOS
too.