Change Configuration.Json to use a regular Dictionary.

[eerhardt]

The other Configuration providers use a regular Dictionary.

This allows for SortedDictionary to be trimmed in a default Blazor WASM app, saving roughly 4 KB .br compressed.

[ghost]

Tagging subscribers to this area: @maryamariyan, @safern
See info in area-owners.md if you want to be subscribed.

Issue Details

---

The other Configuration providers use a regular Dictionary.

This allows for SortedDictionary to be trimmed in a default Blazor WASM app, saving roughly 4 KB .br compressed.

Author:	eerhardt
Assignees:	-
Labels:	area-Extensions-Configuration
Milestone:	-

[ghost]

Tagging subscribers to 'size-reduction': @eerhardt, @SamMonoRT, @marek-safar, @tannergooding, @CoffeeFlux
See info in area-owners.md if you want to be subscribed.

Issue Details

---

The other Configuration providers use a regular Dictionary.

This allows for SortedDictionary to be trimmed in a default Blazor WASM app, saving roughly 4 KB .br compressed.

Author:	eerhardt
Assignees:	-
Labels:	area-Extensions-Configuration, size-reduction
Milestone:	-

[stephentoub]

If the order of the data returned to the consumer isn't important, LGTM. But I wonder why this was using a SortedDictionary in the first place.

[davidfowl]

I'm wondering if it was trying to preserve ordering from the original file. The way things would be overwritten is preserved?

[eerhardt]

If the order of the data returned to the consumer isn't important, LGTM. But I wonder why this was using a SortedDictionary in the first place.

I'm really not sure. I looked at the original PR aspnet/Configuration#186, and there were no comments why it was using sorted. There isn't a test for it to be sorted.

Also, the other file configuration providers use a regular Dictionary:

runtime/src/libraries/Microsoft.Extensions.Configuration.Xml/src/XmlStreamConfigurationProvider.cs

Lines 250 to 269 in c24bf80

	var configuration = new Dictionary<string, string>(StringComparer.OrdinalIgnoreCase);
	if (root == null)
	{
	return configuration;
	}
	var rootPrefix = new Prefix();
	// The root element only contributes to the prefix via its Name attribute
	if (!string.IsNullOrEmpty(root.Name))
	{
	rootPrefix.Push(root.Name);
	}
	ProcessElementAttributes(rootPrefix, root);
	ProcessElementContent(rootPrefix, root);
	ProcessElementChildren(rootPrefix, root);
	return configuration;

runtime/src/libraries/Microsoft.Extensions.Configuration.Ini/src/IniStreamConfigurationProvider.cs

Lines 26 to 29 in c24bf80

	public static IDictionary<string, string> Read(Stream stream)
	{
	var data = new Dictionary<string, string>(StringComparer.OrdinalIgnoreCase);
	using (var reader = new StreamReader(stream))

I'm not sure how to find the answer. Is there someone from the ASP.NET team that is an expert on configuration?

[safern]

Maybe @HaoK can help here.

[HaoK]

I don't have any context here either as this code was before my time on config as well. The order of the keys for any particular configuration provider shouldn't matter as its just the existence of a key that determines whether its a hit for config lookup purposes. I guess the relevant method that might be affected is GetChildKeys which also seems to do some sorting...

runtime/src/libraries/Microsoft.Extensions.Configuration/src/ConfigurationProvider.cs

Line 91 in 79ae74f

results.Sort(ConfigurationKeyComparer.Comparison);

[davidfowl]

I spoke to the original author and it seems like this may not have been necessary. Carry on.

[HaoK]

I was about to say, lets ask Lou if he remembers :)

[davidfowl]

Wait did Lou write this, I asked victor 🤣

[HaoK]

Nope, you are right, it was Victor, i found the commit: aspnet/Configuration@0517eee

[victorhurdugaci]

👋 I have no idea why I wanted the keys to be sorted. I told David that my best guess is that I was trying to preserve the order of elements in arrays but, if that was my intention, the implementation is buggy past 10 elements... So 🤷 sorry...

[davidfowl]

/azp run runtime

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).