Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LoggingGenerator #51064

Merged
merged 123 commits into from
Apr 16, 2021
Merged

Add LoggingGenerator #51064

merged 123 commits into from
Apr 16, 2021

Commits on Nov 17, 2020

  1. Rejigger project names

    Martin Taillefer committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    71cf1eb View commit details
    Browse the repository at this point in the history
  2. Update namespaces

    Martin Taillefer committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    afd85ab View commit details
    Browse the repository at this point in the history
  3. Nuke the temporary .Attributes namespace

    Martin Taillefer committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    fe21a95 View commit details
    Browse the repository at this point in the history
  4. Add error checking to prevent multiple logging messages from using th…

    …e same event id
    Martin Taillefer committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    b6281b5 View commit details
    Browse the repository at this point in the history
  5. Use ISyntaxReceiver to be more IDE friendly

    The `ISyntaxReceiver` is a syntax model that is more IDE friendly than
    the pull model that was previously implemented. This allows the IDE to
    push data to the generator as it is processing it. This is important
    because the IDE is constantly "abandoning" analysis as the customer
    types in the IDE which invalidates state and they quickly want to move
    to calculating the new state
    jaredpar committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    ca3ead4 View commit details
    Browse the repository at this point in the history
  6. Finish implementation of exception support

    Martin Taillefer committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    470b160 View commit details
    Browse the repository at this point in the history
  7. Make the generated type have the same access modifiers as the input i…

    …nterface type
    Martin Taillefer committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    515f029 View commit details
    Browse the repository at this point in the history
  8. Enforce that logging methods must return void

    Martin Taillefer committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    6affdd8 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2020

  1. Cleanup how semantic models are handled

    Martin Taillefer committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    7f15797 View commit details
    Browse the repository at this point in the history
  2. Prevent generic interfaces or methods.

    Martin Taillefer committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    8b3cdaa View commit details
    Browse the repository at this point in the history
  3. Improve efficiency of the generated code for log messages without tem…

    …plates
    Martin Taillefer committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    1c0e756 View commit details
    Browse the repository at this point in the history
  4. Various cleanup items

    Martin Taillefer committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    5893090 View commit details
    Browse the repository at this point in the history
  5. Few small changes (#3)

    - Use the logger factory and console logger in the sample
    - Support overriding the event name via the logger message attribute
    - Added ToString override
    - Enable dumping generated code in the sample for easy debugging
    davidfowl committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    56943dd View commit details
    Browse the repository at this point in the history
  6. Minor refactoring

    Martin Taillefer committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    056e81c View commit details
    Browse the repository at this point in the history
  7. More refactoring

    Martin Taillefer committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    b72ec2d View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2020

  1. Configuration menu
    Copy the full SHA
    4ab2acc View commit details
    Browse the repository at this point in the history
  2. Optimize some code gen.

    - GetEnumerator is now implemented by calling the indexer to avoid
    some redundant code.
    
    - Logging methods without arguments now share a common log state
    struct, which eliminates redundant code to JIT.
    Martin Taillefer committed Nov 19, 2020
    Configuration menu
    Copy the full SHA
    0718293 View commit details
    Browse the repository at this point in the history
  3. Simplify the model. You can now only annotate partial methods

    Martin Taillefer committed Nov 19, 2020
    Configuration menu
    Copy the full SHA
    d065c90 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2020

  1. Improve code generation by statically defining delegate types

    Martin Taillefer committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    d99cec0 View commit details
    Browse the repository at this point in the history
  2. Simplify generated code

    Martin Taillefer committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    b31bca8 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2020

  1. Revamp code gen to shrink jitted size

    Martin Taillefer committed Nov 21, 2020
    Configuration menu
    Copy the full SHA
    1a4e336 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2020

  1. Bunch of improvements.

    - Add error checking to ensure the first argument to a logging method
    implements the ILogger interface.
    
    - Can now specify logging methods with generic
    ILogger<T> as logger.
    
    - Add error checking to prevent generic logging method parameters.
    
    - Add error checking to ensure logging methods are static and partial
    
    - Can now specify logging methods which different access modifiers.
    
    - Eliminate or reduce cascading errors in many cases.
    
    - Ensure generated symbol names all start with __ so as not to conflict
    with user-specified symbols
    Martin Taillefer committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    128f5d2 View commit details
    Browse the repository at this point in the history
  2. Enable localization of error messages

    Martin Taillefer committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    3740b68 View commit details
    Browse the repository at this point in the history
  3. Substantially reduce the size of the generated code

    Martin Taillefer committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    e275551 View commit details
    Browse the repository at this point in the history
  4. Add unit tests for Microsoft.Extensions.Logging.Attributes

    Martin Taillefer committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    fc8ce48 View commit details
    Browse the repository at this point in the history
  5. Renamed the *Attributes assembly to *Extras

    Martin Taillefer committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    951f5cc View commit details
    Browse the repository at this point in the history
  6. Remove an allocation that snuck in during the last batch of optimizat…

    …ions
    Martin Taillefer committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    bf36548 View commit details
    Browse the repository at this point in the history
  7. Add a few more tests

    Martin Taillefer committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    b773ce8 View commit details
    Browse the repository at this point in the history
  8. Use proper code to get fully-qualified type names

    Martin Taillefer committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    6b25016 View commit details
    Browse the repository at this point in the history
  9. Add support for message strings containing linefeeds or quotes

    Martin Taillefer committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    1eb4e9f View commit details
    Browse the repository at this point in the history
  10. Add support for logging messages containing carriage returns.

    Martin Taillefer committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    bb45336 View commit details
    Browse the repository at this point in the history
  11. Use static analysis consistently

    Martin Taillefer committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    e979d5f View commit details
    Browse the repository at this point in the history
  12. More tests, and a fix for string formatting of large cardinality log …

    …messages
    Martin Taillefer committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    c459d32 View commit details
    Browse the repository at this point in the history
  13. Add code coverage for logging generator error paths

    Martin Taillefer committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    14530de View commit details
    Browse the repository at this point in the history
  14. Readme update

    Martin Taillefer committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    d0ebfb2 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2020

  1. Add support for early termination via the cancellation token

    Martin Taillefer committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    6354e8f View commit details
    Browse the repository at this point in the history
  2. Improvements in the code generator's performance

    Martin Taillefer committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    8ece920 View commit details
    Browse the repository at this point in the history
  3. Produce an error when [LoggerMessage] is applied to a non-partial met…

    …hod in a non-partial class
    Martin Taillefer committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    0167f30 View commit details
    Browse the repository at this point in the history
  4. Add support for generic parameters for logging methods

    Martin Taillefer committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    9915bbd View commit details
    Browse the repository at this point in the history
  5. Add support for 'protected internal' and 'protected private' logging …

    …methods
    Martin Taillefer committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    43f671c View commit details
    Browse the repository at this point in the history
  6. Minor cleanup

    Martin Taillefer committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    66310a1 View commit details
    Browse the repository at this point in the history
  7. Improved code gen for log levels, and add level unit tests

    Martin Taillefer committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    58709eb View commit details
    Browse the repository at this point in the history
  8. Add support for ToString in the log state

    Martin Taillefer committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    11b5ef1 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2020

  1. Introduce an analyzer.

    - The analyzer flags use of legacy logging methods. The matching fixer
    hasn't been implemented yet, but it'll make it easy to convert a legacy
    logging method call into a new strongly-typed logger call instead.
    
    - Add support for convert logging method parameters to pascal case.
    Martin Taillefer committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    da8099b View commit details
    Browse the repository at this point in the history
  2. Combine the fixer into the analyzer assembly.

    Martin Taillefer committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    dd39eba View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2020

  1. Introduce analyzer and fixer functionality

    Martin Taillefer committed Nov 27, 2020
    Configuration menu
    Copy the full SHA
    a93b5c0 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2020

  1. More stuff.

    - Build a testing infra to make it possible to test the fixer.
    
    - Updating dependencies across projects
    
    - The analyzer now highlights Log() methods and the fixer can
    deal with those too.
    Martin Taillefer committed Nov 28, 2020
    Configuration menu
    Copy the full SHA
    17d3a5b View commit details
    Browse the repository at this point in the history
  2. More tests, and ensuing bug fixes.

    Martin Taillefer committed Nov 28, 2020
    Configuration menu
    Copy the full SHA
    561dbf3 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2020

  1. Tests and fixes

    Martin Taillefer committed Nov 29, 2020
    Configuration menu
    Copy the full SHA
    8f94d10 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2020

  1. Configuration menu
    Copy the full SHA
    34d2237 View commit details
    Browse the repository at this point in the history
  2. Add license file and a bit of info in the README

    Martin Taillefer committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    6fabebc View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2020

  1. Improve generator's perf to minimize the impact on the IDE

    Martin Taillefer committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    438f2bb View commit details
    Browse the repository at this point in the history
  2. Refactor the main generator class to allow unit testing of the produc…

    …tion logic
    Martin Taillefer committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    3fd97a1 View commit details
    Browse the repository at this point in the history
  3. More test coverage, more resulting fixes

    Martin Taillefer committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    9c6c08b View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2020

  1. Make the source generator robust to malformed source

    Martin Taillefer committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    71fd60a View commit details
    Browse the repository at this point in the history
  2. More testing and tweaking

    Martin Taillefer committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    4424c8b View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2020

  1. More coverage, more fixes

    Martin Taillefer committed Dec 3, 2020
    Configuration menu
    Copy the full SHA
    bb33d1c View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2020

  1. Relocate using statements

    Martin Taillefer committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    c89bb35 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2020

  1. Cleanup analyzer story

    Martin Taillefer committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    755f3ff View commit details
    Browse the repository at this point in the history

Commits on Dec 26, 2020

  1. Refactoring and cleanup

    Martin Taillefer committed Dec 26, 2020
    Configuration menu
    Copy the full SHA
    225b63d View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2020

  1. Get coverage to 100%

    Martin Taillefer committed Dec 29, 2020
    Configuration menu
    Copy the full SHA
    139e5bb View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2021

  1. A few improvements

    - The code generator reports a few more errors.
    
    - Substantially improve the little Roslyn testing framework ignored
    created for this.
    
    - A few analysis-driven improvements.
    Martin Taillefer committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    e8db38a View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2021

  1. Variety of improvements.

    - Added support for dynamic log levels. Rather than putting the
    log level in the [LoggerMessage] attribute, you can put it as
    an argument to the logging method. This allows dynamic log levels.
    
    - Made the LogStateHolder types classes instead of structs. This
    dedicates one allocation in order to save multiple boxings of the
    struct within the ILogger implementation. In addition, the generated
    code ends up faster because it doesn't have to copy around a potentially
    large struct.
    
    - Fix logic that was parsing the [LoggerMessage] attribute values. it
    wasn't dealing with using name: syntax to initialize the values of an
    attribute.
    Martin Taillefer committed Mar 14, 2021
    Configuration menu
    Copy the full SHA
    5e3d279 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2021

  1. Various improvements.

    - The ILogger parameter to logging methods no longer needs to be the
    first argument in the logging method. As long as it is one of the
    arguments, everything will work.
    
    - Support specifying the [LoggerMessage] attribute without an actual
    message string. When this happens, an auto-generated message string
    is produced which outputs the logging method parameters in JSON
    format.
    
    - Fixed bug where the LogStateHolder object was being populated with
    exception and log level objects when those should have been stripped
    away
    
    - Specifying an argument to a logging method, but not supplying a
    template for it in the log message is now treated as a warning instead
    of an error.
    Martin Taillefer committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    00cac9b View commit details
    Browse the repository at this point in the history
  2. Add support for logging methods as instance methods

    Martin Taillefer committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    9e150d9 View commit details
    Browse the repository at this point in the history
  3. Minor cleanup

    Martin Taillefer committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    83eb36e View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2021

  1. Various improvements

    - Add support for the EmitDefaultMessages generator option which
    controls whether default messages are produced if the user doesn't
    supply one.
    
    - Add support for the FieldName generator option which determines
    the name of the field used to retrieve the logger instance when
    using instance mode logging methods.
    
    - Add support for the {OriginalFormat} element when enumerating the
    TState. This is for compatibility with the existing LoggerMessage.Define
    method.
    
    - Add support for automatically expanding IEnumerable logging method
    parameters to comma-separated strings. This is for compatibility
    with the LoggerMessage.Define method.
    Martin Taillefer committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    cc44192 View commit details
    Browse the repository at this point in the history
  2. Rename LogStateHolder to LogValues

    Martin Taillefer committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    b611bbd View commit details
    Browse the repository at this point in the history
  3. Improve test coverage

    Martin Taillefer committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    60fef62 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2021

  1. Use the Invariant culture when formatting log messages

    Martin Taillefer committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    79dc2d4 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2021

  1. Improve the error message around id reuse

    Martin Taillefer committed Mar 27, 2021
    Configuration menu
    Copy the full SHA
    055cf3f View commit details
    Browse the repository at this point in the history
  2. A few improvements

    - For instance-mode logging method, the code now binds to any single
    field that implements ILogger. The code generates an error if there
    are multiple matching fields. The code doesn't currently look up the
    inheritance hierarchy for fields or properties that match, it certainly
    could in the future if that is deemed useful.
    
    - Remove the global option to control the field name used for instance
    methods, since the field is now determined dynamically based on type.
    
    - Made a few diagnostics into warnings since they were really just
    advisory in nature.
    
    - Cleaned up the diagnostic and resource string names for better
    consistency.
    Martin Taillefer committed Mar 27, 2021
    Configuration menu
    Copy the full SHA
    abb5010 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2021

  1. Configuration menu
    Copy the full SHA
    9087427 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2021

  1. Minor cleanup items

    Martin Taillefer committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    58b3369 View commit details
    Browse the repository at this point in the history
  2. Added preliminary support for an alternate code gen strategy

    Martin Taillefer committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    82f1611 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2021

  1. Overhaul of the emitter.

    - Use LoggerMessage.Define as the implementation mechanism in the common
    case. This eliminates the need to introduce public LogValues types.
    
    - When LoggerMessage.Define is not sufficient, the code generator now
    emits custom structs to accommodate features that LoggerMessage.Define
    doesn't support.
    Martin Taillefer committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    bb63032 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2021

  1. Address more feedback and bugs

    * Remove the code that was warning for the use of DateTime as a parameter.
    
    * Fix bug where the code wasn't handling repeating the ssme template multiple times since switching to the new code gen model.
    
    * Fix bug where the code wasn't handling out of order templates relative
    to the logging parameters. This also broke when updating the code gen
    model.
    
    * Remove support for optional message strings, and the JSON encoding that
    was used in that case.
    
    * Make it so specifying a logger template is now a warning instead of
    an error.
    
    * Add three disabled tests (search for TODO) which identify more
    error cases the parser should report. These checks should be
    implemented soon.
    
    * Remove support for optionally pascal casing arguments. Instead,
    the exact casing used in the TState's IReadOnlyList is now derived from the
    template.
    
    * Templatet-to-parameter matching is now case-insensitive.
    
    * Remove support for global options since there was nothing left to control.
    Martin Taillefer committed Apr 10, 2021
    Configuration menu
    Copy the full SHA
    5f210fc View commit details
    Browse the repository at this point in the history
  2. Two nit fixes

    maryamariyan committed Apr 10, 2021
    Configuration menu
    Copy the full SHA
    fe54581 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #2 from maryamariyan/nit-fixes

    Two nit fixes
    maryamariyan committed Apr 10, 2021
    Configuration menu
    Copy the full SHA
    407a9e8 View commit details
    Browse the repository at this point in the history
  4. API Review feedback: LoggerMessageAttribute (#4)

    * API Review feedback: LoggerMessageAttribute
    * switch event id default to -1
    * Update docs regarding message not provided
    TODO
    - [ ] disable accepting empty message feature if needed
    maryamariyan committed Apr 10, 2021
    Configuration menu
    Copy the full SHA
    b1f5364 View commit details
    Browse the repository at this point in the history
  5. Merge branch 'logging-generator' of /Users/maryam/CodeHub/LoggingGene…

    …rator into logging-gen-p4
    maryamariyan committed Apr 10, 2021
    Configuration menu
    Copy the full SHA
    3afda5f View commit details
    Browse the repository at this point in the history
  6. - Update header license

    maryamariyan committed Apr 10, 2021
    Configuration menu
    Copy the full SHA
    b7b2928 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c41c463 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2021

  1. - Add LoggerMessageAttribute - ref/src

    - Fix build on csproj
    - Make InternalsVisibleTo in test for DiagDescriptors asserts
    - Fix name typos in sln and cs file
    maryamariyan committed Apr 11, 2021
    Configuration menu
    Copy the full SHA
    3ef2083 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a7eba74 View commit details
    Browse the repository at this point in the history
  3. - ActiveIssue for Mono

    - Fix path separator used for test file location
    maryamariyan committed Apr 11, 2021
    Configuration menu
    Copy the full SHA
    ba71c47 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4cb1466 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2021

  1. Configuration menu
    Copy the full SHA
    daf1a7a View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2021

  1. Configuration menu
    Copy the full SHA
    3a97c73 View commit details
    Browse the repository at this point in the history
  2. - Switch ActiveIssue from closed to dupe one.

    - Add attribute at the type level.
    maryamariyan committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    946f764 View commit details
    Browse the repository at this point in the history
  3. - Move RoslynTestUtils to common folder

    - Correct namespaces
    maryamariyan committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    80840e6 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5637b69 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0cc8316 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    1297f11 View commit details
    Browse the repository at this point in the history
  7. - Remove LangVersions from csproj

    - Remove "_ = " from test project
    - Remove suppressed warnings in RoslynTestUtils
    - Use explicit types (not var) in RoslynTestUtils
    - GetAssembly -> typeof(..).Assembly
    - Use a globbing pattern to copy TestClasses to output
    - Remove TreatWarningAsError, on by default
    - Correct expected assertions for MessageTest
    maryamariyan committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    2add7ce View commit details
    Browse the repository at this point in the history
  8. - Remove Moq

    - Remove InternalsVisibleTo on M.E.DependencyModel.Tests
    - Undo add ReferenceOutputAssembly on Logging Generator
    - Diff in ParserTests: use explicit type (not var), rename some vars
    - Diff in LoggerMessageGeneratorX files: use explicit type (not var)
    maryamariyan committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    13631d2 View commit details
    Browse the repository at this point in the history
  9. - Skip on browser Cant load Microsoft.CodeAnalysis

    - Remove from gen csproj: RestoreAdditionalProjectSources
    - Remove unused `LoggerField = "_logger";` instantiation
    maryamariyan committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    d9970f7 View commit details
    Browse the repository at this point in the history
  10. - Add CLSCompliant on gen csproj

    - Dont need Microsoft.CodeAnalysis.Analyzers for gen csproj
    - Dont need InternalsVisibleTo for gen in test csproj
    - Remove many unnecessary p2p refs in test csproj
    - Remove FixIncrementalCoreCompileWithAnalyzers target
    maryamariyan committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    d809dad View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2021

  1. - Add record of SYSLIBXXXX in the md file

    - Change SYSLIBXXXX IDs to unique for analyzers
    - Move MicrosoftCodeAnalysisCSharpWorkspacesVersion in versions.props
    - Set generator test as ProjectExclusions when TargetsMono is true
    - Remove AssemblyInfo.cs not needed
    maryamariyan committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    dd51c53 View commit details
    Browse the repository at this point in the history
  2. - Rename md file to list-of-diagnostics.md

    - "_ = sb" -> "sb" in Emitter.cs
    - Remove dead code in test csproj
    - Add MicrosoftCodeAnalysisVersion to versions.props
    maryamariyan committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    70f24ef View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    afb43d7 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2d41c6d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7e68b1c View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2021

  1. Refactor part 1

    maryamariyan committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    9200131 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6a71553 View commit details
    Browse the repository at this point in the history
  3. Refactor part 2

    maryamariyan committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    7547f38 View commit details
    Browse the repository at this point in the history
  4. - Remove duplication in the resource string values

    - Fix random PR feedback
    maryamariyan committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    6eab93d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    cc0bb07 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e56d447 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    b970fdd View commit details
    Browse the repository at this point in the history
  8. - Can't have a log level set twice

    set in both the attribute and as a logging method parameter
    maryamariyan committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    bd93ccf View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    a6ecab3 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    35a584c View commit details
    Browse the repository at this point in the history
  11. Renames only

    maryamariyan committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    0ec16c4 View commit details
    Browse the repository at this point in the history
  12. - Use other Define overload using skipEnabledCheck

    - .Clear() the builder in between calls to Emit
    - Add comments
    - Use globbing pattern for *.generated.txt
    - Optimize code to convert message to escape form
    - Move example/remarks in triple slash docs for attribute class
    - Don't call context.AddSource when no logClass are there
    maryamariyan committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    e81015d View commit details
    Browse the repository at this point in the history
  13. Revert "Upgrade generator package versions"

    This reverts commit b970fdd.
    maryamariyan committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    1b7a158 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    d94e42f View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2021

  1. Configuration menu
    Copy the full SHA
    a2f18d9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e110684 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ba9b77f View commit details
    Browse the repository at this point in the history
  4. lock strings

    maryamariyan committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    843c0f3 View commit details
    Browse the repository at this point in the history
  5. - Feedback on RoslynTestUtils

    - Feedback on ConvertEndOfLineAndQuotationCharactersToEscapeForm
    maryamariyan committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    65b1f51 View commit details
    Browse the repository at this point in the history
  6. - Enable nullable on csproj

    - Add comment in versions.props
    - Nit code style feedback
    - Dont keep method when starts with underscore
    maryamariyan committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    c0c22ce View commit details
    Browse the repository at this point in the history