Increase SslStream FrameOverhead estimation for newer TLS protocols #51320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl, @vcsjones Issue DetailsFrom #51060 (comment) Resolves #51076
|
|
I'm fine with this... @wfurt any concerns here? |
stephentoub
reviewed
Apr 15, 2021
src/libraries/System.Net.Security/src/System/Net/Security/SslStream.Implementation.cs
Show resolved
Hide resolved
stephentoub
approved these changes
Apr 15, 2021
benaadams
commented
Apr 15, 2021
src/libraries/System.Net.Security/src/System/Net/Security/SslStream.Implementation.cs
Show resolved
Hide resolved
benaadams
commented
Apr 15, 2021
src/libraries/System.Net.Security/src/System/Net/Security/SslStream.Implementation.cs
Outdated
Show resolved
Hide resolved
|
Oh no, did we turn on style cop? Failing the build because of whitespace?! My take is (having been in a repo where this was on before), that finding a way to auto format is much better than failing the build... |
Yes, years ago. |
benaadams
commented
Apr 16, 2021
src/libraries/System.Net.Security/src/System/Net/Security/SslStream.Implementation.cs
Outdated
Show resolved
Hide resolved
|
CI looks like its not starting; will rebase to kick |
benaadams
force-pushed
the
Increase-SslStream-Frameoverhead
branch
from
19e15cf
to
d8df69f
Compare
|
Both Installer Build failures are #51372 |
benaadams
force-pushed
the
Increase-SslStream-Frameoverhead
branch
from
d8df69f
to
df490de
Compare
|
Rebased to clear the failed tests that no longer seem to be part of CI |
|
🥳 |
|
Thanks @benaadams |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #51060 (comment)
Before
After
Resolves #51076