Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve ILLink warnings in System.ComponentModel.TypeConverter (Final) #51344

Merged
merged 2 commits into from
Apr 16, 2021
Merged

Resolve ILLink warnings in System.ComponentModel.TypeConverter (Final) #51344

merged 2 commits into from
Apr 16, 2021

Conversation

eerhardt
Copy link
Member

Contributes to #45623

@ghost
Copy link

ghost commented Apr 15, 2021

Tagging subscribers to this area: @safern
See info in area-owners.md if you want to be subscribed.

Issue Details

Contributes to #45623

Author: eerhardt
Assignees: -
Labels:

area-System.ComponentModel
Milestone: -

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@eerhardt eerhardt added linkable-framework Issues associated with delivering a linker friendly framework and removed new-api-needs-documentation labels Apr 15, 2021
@ghost
Copy link

ghost commented Apr 15, 2021

Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @tannergooding, @sbomer
See info in area-owners.md if you want to be subscribed.

Issue Details

Contributes to #45623

Author: eerhardt
Assignees: -
Labels:

area-System.ComponentModel, linkable-framework
Milestone: -

joperezr
joperezr approved these changes Apr 16, 2021
View reviewed changes
Copy link
Member

@joperezr joperezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a question more for my understanding than anything else, but other than that this looks good.

@eerhardt eerhardt mentioned this pull request Apr 16, 2021
Closed
@eerhardt
Copy link
Member Author

Libraries test failure is #48851
Installer test failures are #51372

@eerhardt eerhardt merged commit 180e5fa into dotnet:main Apr 16, 2021
@eerhardt eerhardt deleted the TypeConverterFinal branch April 16, 2021 20:54
@ghost ghost locked as resolved and limited conversation to collaborators May 16, 2021
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joperezr joperezr joperezr approved these changes

@vitek-karas vitek-karas vitek-karas approved these changes

@stephentoub stephentoub stephentoub approved these changes

@krwq krwq Awaiting requested review from krwq

Assignees
No one assigned
Labels
area-System.ComponentModel linkable-framework Issues associated with delivering a linker friendly framework
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@eerhardt @stephentoub @vitek-karas @joperezr @karelz