Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crossgen2 build #51349

Merged
merged 7 commits into from
Apr 16, 2021
Merged

Fix crossgen2 build #51349

merged 7 commits into from
Apr 16, 2021

Conversation

davidwrighton
Copy link
Member

@davidwrighton davidwrighton commented Apr 15, 2021 •
edited
Loading

  • Include osx arm64 jit in package
    • Also use that jit when appropriate
  • build for all rids
  • build cross targeting test scenario variant from separate project file to avoid issue with incorrect app host rid
    • Remove app host from cross targeting x64 crossgen used in test scenarios

Addresses #50514

@davidwrighton
Copy link
Member Author

@dotnet/crossgen-contrib

trylek
trylek approved these changes Apr 15, 2021
View reviewed changes
Copy link
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thank you!

AntonLapounov
AntonLapounov approved these changes Apr 16, 2021
View reviewed changes
Copy link
Member

@AntonLapounov AntonLapounov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

src/coreclr/tools/Common/JitInterface/JitConfigProvider.cs Show resolved Hide resolved
src/coreclr/tools/aot/crossgen2/crossgen2_crossarch.csproj Show resolved Hide resolved
src/coreclr/tools/aot/crossgen2/crossgen2.props Outdated Show resolved Hide resolved
@davidwrighton davidwrighton merged commit be307a8 into dotnet:main Apr 16, 2021
@mfilippov mfilippov mentioned this pull request Apr 17, 2021
Closed
@AntonLapounov AntonLapounov mentioned this pull request Apr 18, 2021
Closed
@clamp03 clamp03 mentioned this pull request Apr 19, 2021
Merged
davidwrighton pushed a commit that referenced this pull request Apr 19, 2021
@clamp03
Fix armel cross build error (#51479)
af011f7 
- Failed by #51349
@omajid
Copy link
Member

omajid commented Apr 22, 2021

As far as I can tell, this breaks building runtime on arm64 (like we do on Fedora). On an arm64 machine:

  crossgen2 -> /home/tester/runtime/artifacts/bin/coreclr/Linux.arm64.Release/crossgen2/crossgen2.dll
/home/tester/runtime/.dotnet/sdk/6.0.100-preview.2.21155.3/Microsoft.Common.CurrentVersion.targets(4941,5): error MSB3030: Could not copy the file "/home/tester/runtime/artifacts/bin/coreclr/Linux.arm64.Release/x64/libjitinterface_x64.so" because it was not found. [/home/tester/runtime/src/coreclr/tools/aot/crossgen2/crossgen2_crossarch.csproj]

@AntonLapounov AntonLapounov mentioned this pull request Apr 22, 2021
Merged
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jun 19, 2021
@davidwrighton davidwrighton deleted the fixCrossgen2Build branch April 13, 2023 18:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AntonLapounov AntonLapounov AntonLapounov approved these changes

@omajid omajid omajid left review comments

@trylek trylek trylek approved these changes

Assignees
No one assigned
Labels
area-crossgen2-coreclr
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@davidwrighton @omajid @trylek @AntonLapounov @karelz