Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ConfigureHostOptions extension method on IHostBuilder #51410

Merged
merged 1 commit into from
Apr 19, 2021

Conversation

IEvangelist
Copy link
Member

@IEvangelist IEvangelist commented Apr 16, 2021

  • Add two ConfigureHostOptions extension methods
  • Add corresponding unit tests to ensure these new methods function correctly

Fixes #48743
Closes #49502 (In draft for a while now)

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Apr 16, 2021

Tagging subscribers to this area: @eerhardt, @maryamariyan
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Add two ConfigureHostOptions extension methods
  • Add corresponding unit tests to ensure these new methods function correctly

Fixes #48743
Closes #49502 (In draft for a while now)

Author: IEvangelist
Assignees: -
Labels:

area-Extensions-Hosting, new-api-needs-documentation

Milestone: -

Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks again for the contributions here.

cc @davidfowl @Tratcher

Copy link
Member

@davidfowl davidfowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@eerhardt
Copy link
Member

Test failures are #51372.

@eerhardt eerhardt merged commit 4ab71ae into dotnet:main Apr 19, 2021
@IEvangelist IEvangelist deleted the config-host-options branch April 19, 2021 19:01
@ghost ghost locked as resolved and limited conversation to collaborators May 19, 2021
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add API to make configuring the HostOptions easier
5 participants