Fixed non-decreasing count of stream on H3 connection. #51742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed testing H/3 loopback stream to properly close. Otherwise, the stream will end up in a bad state and the connection will eventually run out of available streams.
|
Tagging subscribers to this area: @dotnet/ncl |
wfurt
approved these changes
Apr 27, 2021
| } | ||
| } | ||
|
|
||
| private void IncreaseRemainingStreamCount(long delta) |
There was a problem hiding this comment.
if delta is negative "AdjustRemainingStreamCount" may be better name.
There was a problem hiding this comment.
It's never <= 0. I added an assert to express that.
JamesNK
approved these changes
Apr 27, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this fixes the problem only for the initially set limit of 100 streams. The more general fix and API will follow with #32079. This is mainly to unblock ASP.NET core scenarios.
Fixes #49617
cc: @JamesNK