Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented ReadAtLeastAsync #51979

Merged
merged 6 commits into from
May 1, 2021
Merged

Implemented ReadAtLeastAsync #51979

merged 6 commits into from
May 1, 2021

Commits on Apr 28, 2021

  1. Implemented ReadAtLeastAsync

    - Implemented the PipeReader implementation and override the method on Pipe.
    - The Pipe implementation has some caveats. Calling ReadAtLeast messes with the pipe back pressure since it's trying to prevent deadlocks. This means that if ReadAsync is called with a big threshold, the writer will write as fast as it can ignoring the PauseThreshold up until the reader is unblocked. In a sense, the call to ReadAtLeast async overrides the pause threshold for that one read.
    - Added tests
    - Added missing StreamConformance tests to the solution so it would build
    davidfowl committed Apr 28, 2021
    Configuration menu
    Copy the full SHA
    cbe6292 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3a95498 View commit details
    Browse the repository at this point in the history
  3. Last minute change broke some tests

    - Flip the reading state off when we decide not to accept the read
    davidfowl committed Apr 28, 2021
    Configuration menu
    Copy the full SHA
    c275673 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2021

  1. PR feedback

    davidfowl committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    0244e36 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    eb597de View commit details
    Browse the repository at this point in the history
  3. Undo back pressure tests

    davidfowl committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    8981f22 View commit details
    Browse the repository at this point in the history