Move AssemblyExtensions.GetApplyUpdateCapabilities to be guarded by Debugger.IsSupported

[eerhardt]

We are currently using the Debugger.IsSupported feature switch to trim out hot reload support. So moving this method to only be preserved when Debugger.IsSupported is true.

#51159 tracks using a separate "hot reload" feature switch if we don't want to tie "debugging" and "hot reload" together.

[dotnet-issue-labeler]

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

[ghost]

Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer
See info in area-owners.md if you want to be subscribed.

Issue Details

---

We are currently using the Debugger.IsSupported feature switch to trim out hot reload support. So moving this method to only be preserved when Debugger.IsSupported is true.

#51159 tracks using a separate "hot reload" feature switch if we don't want to tie "debugging" and "hot reload" together.

Author:	eerhardt
Assignees:	-
Labels:	linkable-framework
Milestone:	-

[jkotas]

Thanks

[lambdageek]

Do we run tests in configurations without a debugger? In that case GetApplyUpdateCapabilitiesIsCallable might need to be a [ConditionalFact]

runtime/src/libraries/System.Runtime.Loader/tests/AssemblyExtensionsTest.cs

Lines 34 to 35 in 636988a

	[Fact]
	public void GetApplyUpdateCapabilitiesIsCallable()

[eerhardt]

Do we run tests in configurations without a debugger?

The one place that I know of that will trim the test with Debugger.IsSupported=false is the AOT wasm tests. The way we solve this for other tests is to set DebuggerSupport to true in the test project. For example:

runtime/src/libraries/System.Diagnostics.StackTrace/tests/System.Diagnostics.StackTrace.Tests.csproj

Lines 7 to 8 in 6ca3d91

	<!-- these tests depend on the pdb files -->
	<DebuggerSupport Condition="'$(DebuggerSupport)' == '' and '$(TargetOS)' == 'Browser'">true</DebuggerSupport>

[eerhardt]

Looking at the test code:

runtime/src/libraries/System.Runtime.Loader/tests/AssemblyExtensionsTest.cs

Lines 37 to 38 in 636988a

	var ty = typeof(System.Reflection.Metadata.AssemblyExtensions);
	var mi = ty.GetMethod("GetApplyUpdateCapabilities", BindingFlags.NonPublic | BindingFlags.Static, Array.Empty<Type>());

The trimmer should be able to recognize this reflection pattern, and not trim the GetApplyUpdateCapabilities method from the assembly in the AOT wasm case. So we should be fine here.