Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid dictionary lookup for singleton services #52035

Merged
merged 6 commits into from
Apr 30, 2021
Merged

Avoid dictionary lookup for singleton services #52035

merged 6 commits into from
Apr 30, 2021

Commits on Apr 29, 2021

  1. Avoid dictionary lookup for singleton services 

    - Stash the instance on the callsite itself and avoid the resolved services lookup.
    @davidfowl
    davidfowl committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    945c4e0 View commit details
    Browse the repository at this point in the history

  2. Small tweaks 

    - Don't lock if the callsite value is already resolved
- Make the value on ServiceCallsite volatile
    @davidfowl
    davidfowl committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    27fb9e8 View commit details
    Browse the repository at this point in the history

  3. Changed resolved services back to dictionary

    @davidfowl
    davidfowl committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    ae637b6 View commit details
    Browse the repository at this point in the history

  4. Fixed tess 

    - cache callsites
- update tests
    @davidfowl
    davidfowl committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    f4d8d38 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2021

  1. PR feedback and cleanup

    @davidfowl
    davidfowl committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    b891ae1 View commit details
    Browse the repository at this point in the history

  2. Remove extra whitespace

    @davidfowl
    davidfowl committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    345c0b7 View commit details
    Browse the repository at this point in the history