System.Reflection.* missed Equals nullable annotations

[hrrrrustic]

No description provided.

[dotnet-issue-labeler]

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

[hrrrrustic]

Ugh, bot didn't ping anyone
@buyaa-n @joperezr @krwq @steveharter
Found all of you in area owners for System.Reflection, sry if I ping someone incorrectly
This PR is continuation of #47598

[hrrrrustic]

Btw there are some changes for reflection in #52167 under CoreLib and I'm not sure whom should I ping for that PR

[buyaa-n]

Thanks @hrrrrustic, could you remove extra castings in the implementation? Other than that LGTM.

[hrrrrustic]

Does it make sense to remove nullable marking here?

runtime/src/libraries/System.Reflection.MetadataLoadContext/src/System/Reflection/TypeLoading/General/RoAssemblyName.cs

Lines 52 to 55 in 3ba6ee1

	public bool Equals(RoAssemblyName? other)
	{
	Debug.Assert(other is not null);
	if (Name != other.Name)

[buyaa-n]

Does it make sense to remove nullable marking here?

runtime/src/libraries/System.Reflection.MetadataLoadContext/src/System/Reflection/TypeLoading/General/RoAssemblyName.cs

Lines 52 to 55 in 3ba6ee1

	public bool Equals(RoAssemblyName? other)
	{
	Debug.Assert(other is not null);
	if (Name != other.Name)

That makes sense, but I guess it has ? because the implemented interface signature has ?, if you remove that you will need to suppress the warning, by accounting that this is an internal type probably no need to remove it

[buyaa-n]

Looks good, thanks @hrrrrustic!

[jeffhandley]

@buyaa-n Once this is merged, please edit the description on dotnet/docs#21202 to include the affected APIs from this PR.

[buyaa-n]

@buyaa-n Once this is merged, please edit the description on dotnet/docs#21202 to include the affected APIs from this PR.

@jeffhandley I do not really think that is necessary, first, this is not breaking change and not really changing the annotation, just adding a [NotNullWhen(true)] for Object.Equals(object obj) overload which applies almost all types that overwrites Object.Equals method which is way too many to add into that issue (most of the annotations added previously here)

EDIT: We might want to add just one generic statement that the attribute is added to the most Object.Equals(object obj) overrides, what you think?

[jeffhandley]

I had noticed that the issue already mentioned #47598, so I thought we'd want to do something similar for other PRs. I don't think we need to call out each specific API. I wasn't sure if any of these could be considered breaking or not.

#47598 [Breaking]
[NotNullWhen(true)] added to hundreds of arguments