Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the SDK to 6.0 Preview 3 #52196

Merged
merged 3 commits into from
May 4, 2021
Merged

Update the SDK to 6.0 Preview 3 #52196

merged 3 commits into from
May 4, 2021

Conversation

ViktorHofer
Copy link
Member

Updating the minimum and target version of the SDK to 6.0 Preview 3.

Contributes to #51716

Updating the minimum and target version of the SDK to 6.0 Preview 3.

Contributes to #51716
@ViktorHofer ViktorHofer added this to the 6.0.0 milestone May 3, 2021
@ViktorHofer ViktorHofer requested a review from a team May 3, 2021 17:30
@ViktorHofer ViktorHofer self-assigned this May 3, 2021
@ghost
Copy link

ghost commented May 3, 2021

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Updating the minimum and target version of the SDK to 6.0 Preview 3.

Contributes to #51716

Author: ViktorHofer
Assignees: ViktorHofer
Labels:

area-Infrastructure

Milestone: 6.0.0

@eerhardt
Copy link
Member

eerhardt commented May 3, 2021

@joperezr - can you look into unblocking the dotnet-linker-tests?

@joperezr
Copy link
Member

joperezr commented May 3, 2021

Sure taking a look

@joperezr
Copy link
Member

joperezr commented May 3, 2021

linker tests are passing locally after that change I just pushed, so hopefully that will be enough for merging.

TL;DR for those interested, the new SDK has now a)Enabled a linker roslyn analyzer by default which was throwing some errors and b) it changed some defaults of when linker warnings are suppressed. My latest commit will just disable the analyzer for our tests and re-add the trimming warning suppressions we had before the sdk bump.

Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The trimming tests changes look fine to me.

@ViktorHofer
Copy link
Member Author

ViktorHofer commented May 4, 2021

@joperezr @eerhardt can you please also look at the remaining linker warnings from the other failing legs?

@eerhardt
Copy link
Member

eerhardt commented May 4, 2021

 error IL2009: (NETCORE_ENGINEERING_TELEMETRY=Build) Could not find method 'ApplyUpdateSdb' on type 'System.Reflection.Metadata.AssemblyExtensions'

Looks like we have a dangling reference to a method that was removed in #51954. I'll remove the entry in the ILLink.Descriptors.xml file.

fyi @lambdageek

- Remove ILLink.Descriptors entry for non-existant method
- Suppress ILLink warnings in mobile tests
@ViktorHofer
Copy link
Member Author

Failure is #11063
The timeout is due to the product build taking 105 minutes which is unacceptable. Likely because of a slow machine again.

@ViktorHofer ViktorHofer merged commit 4c7ae35 into main May 4, 2021
@ViktorHofer ViktorHofer deleted the ViktorHofer-sdkupgrade-p3 branch May 4, 2021 18:29
@ghost ghost locked as resolved and limited conversation to collaborators Jun 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants