-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the SDK to 6.0 Preview 3 #52196
Conversation
Updating the minimum and target version of the SDK to 6.0 Preview 3. Contributes to #51716
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsUpdating the minimum and target version of the SDK to 6.0 Preview 3. Contributes to #51716
|
@joperezr - can you look into unblocking the dotnet-linker-tests? |
Sure taking a look |
linker tests are passing locally after that change I just pushed, so hopefully that will be enough for merging. TL;DR for those interested, the new SDK has now a)Enabled a linker roslyn analyzer by default which was throwing some errors and b) it changed some defaults of when linker warnings are suppressed. My latest commit will just disable the analyzer for our tests and re-add the trimming warning suppressions we had before the sdk bump. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The trimming tests changes look fine to me.
Looks like we have a dangling reference to a method that was removed in #51954. I'll remove the entry in the ILLink.Descriptors.xml file. fyi @lambdageek |
- Remove ILLink.Descriptors entry for non-existant method - Suppress ILLink warnings in mobile tests
Failure is #11063 |
Updating the minimum and target version of the SDK to 6.0 Preview 3.
Contributes to #51716