Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some cleanup around PInvokeStaticSigInfo #52232

Merged
merged 4 commits into from
May 5, 2021
Merged

Some cleanup around PInvokeStaticSigInfo #52232

merged 4 commits into from
May 5, 2021

Conversation

elinor-fung
Copy link
Member

@elinor-fung elinor-fung commented May 4, 2021 •
edited
Loading

  • Trying to make it a little clearer how PInvokeStaticSigInfo gets created/used
  • Remove unused parameter in MetaSig::GetCallingConvention

cc @AaronRobinsonMSFT @jkoritzinsky

@elinor-fung elinor-fung marked this pull request as ready for review May 4, 2021 17:26
@AaronRobinsonMSFT AaronRobinsonMSFT added this to the 6.0.0 milestone May 4, 2021
AaronRobinsonMSFT
AaronRobinsonMSFT approved these changes May 4, 2021
View reviewed changes
src/coreclr/vm/dllimport.cpp Outdated Show resolved Hide resolved
src/coreclr/vm/dllimport.cpp Show resolved Hide resolved
@elinor-fung elinor-fung merged commit a792d3e into dotnet:main May 5, 2021
@elinor-fung elinor-fung deleted the pinvokeStaticSigInfoCleanup branch May 7, 2021 02:11
@ghost ghost locked as resolved and limited conversation to collaborators Jun 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AaronRobinsonMSFT AaronRobinsonMSFT AaronRobinsonMSFT approved these changes

Assignees
No one assigned
Labels
area-Interop-coreclr
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@elinor-fung @AaronRobinsonMSFT