[iOS][tvOS][tests] Re add ios tvos simulator functional tests #52606
Conversation
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsThe iOS simulator and tvOS simulator AOT functional tests had been removed in a previous commit, but instead, they will be brought back for local development usage, and skipped on CI until we add a way to bypass the
|
| @@ -0,0 +1,18 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
There was a problem hiding this comment.
We could try something like
<Project Sdk="Microsoft.NET.Sdk" TreatAsLocalProperty="MonoForceInterpreter" >and then set MonoForceInterpreter to false in this project.
There was a problem hiding this comment.
I'll try that in a follow up PR, one to just target running this particular test project on CI.
src/libraries/tests.proj
Outdated
|
|
||
| <!-- Can't AOT in interp mode --> | ||
| <ProjectExclusions Condition="'$(MonoForceInterpreter)' == 'true'" | ||
| Include="$(RepoRoot)\src\tests\FunctionalTests\iOS\Simulator\AOT\**\*.Test.csproj" /> |
There was a problem hiding this comment.
nit: Perhaps, no need to add a backslash after $(RepoRoot)
There was a problem hiding this comment.
It seems the other instances of $(RepoRoot) are of similar style
mdh1418
force-pushed
the
add_ios_tvos_simulator_functional_tests
branch
2 times, most recently
from
ade150d
to
65eadfd
Compare
|
The 3 failing lanes in the previous run (before having to fix the merge conflict in |
|
The failing lane is unrelated |
ghost
locked as resolved and limited conversation to collaborators
The iOS simulator and tvOS simulator AOT functional tests had been removed in a previous commit, but instead, they will be brought back for local development usage, and skipped on CI until we add a way to bypass the
Global property cannot be modifiederror.