Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VirtualStaticsInInterfaces flag to RuntimeFeature #52733

Merged
merged 2 commits into from
May 14, 2021

Conversation

davidwrighton
Copy link
Member

Based on approved api in #49905. This won't be merged until at least the coreclr runtime is capable.

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@davidwrighton
Copy link
Member Author

@lambdageek Are you ok with merging this change before enabling the feature in mono? I'd prefer to get this in (and the initial coreclr implementation) before the deadline for Preview5, but if you'd prefer to hold off, that can probably also work.
@trylek fyi, when we merge the implementation of the interface static methods, this is the next thing, then crossgen2 and deciding if the feature should have default interface method support in the V1 release.

@lambdageek
Copy link
Member

@davidwrighton yep, no need to wait for mono.

@davidwrighton davidwrighton marked this pull request as ready for review May 14, 2021 22:05
Copy link
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@davidwrighton davidwrighton merged commit 1e48704 into dotnet:main May 14, 2021
@davidwrighton davidwrighton deleted the virtualstaticthing branch May 14, 2021 23:29
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jun 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants