Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GeneratedDllImport in System.Security.Cryptography.Algorithms #53245

Conversation

elinor-fung
Copy link
Member

Library Original (B) Converted (B) + (B) + (%)
linux 221696 249344 27648 12.47
windows 251392 264192 12800 5.09
linux R2R 692224 795648 103424 14.94
windows R2R 762880 814080 51200 6.71

We could probably get some size improvements by switching a few arguments to pointers, but I would rather first focus on getting through the initial conversion so we have a good sense of the overall impact (and then we can look to reduce the size impact).

Lots of great candidates in here for the (ReadOnly)Span support.

cc @AaronRobinsonMSFT @jkoritzinsky

Copy link
Member

@AaronRobinsonMSFT AaronRobinsonMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elinor-fung elinor-fung merged commit efaa1fe into dotnet:feature/use-dllimport-generator May 25, 2021
@elinor-fung elinor-fung deleted the convert-CryptographyAlgorithms branch May 25, 2021 22:36
@ghost ghost locked as resolved and limited conversation to collaborators Jun 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants