Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not eliminate casts from FP types when optimizing narrow stores #53667

Merged
merged 1 commit into from
Jul 13, 2021
Merged

Do not eliminate casts from FP types when optimizing narrow stores #53667

merged 1 commit into from
Jul 13, 2021

Commits on Jun 7, 2021

  1. Do not eliminate casts from FP types 

    An optimization in morph was deleting casts
on the RHS of a narrow store if the cast-to-type
was wider than the type being stored. This is only
valid for casts from integral types, as the backend
does not handle "STOREIND(byte*, double)", nor is there
an instruction to go from an XMM register to a narrow
memory location on x86/x64.

The issue is not reproducible right now because
fgMorphCast wraps the casts in question, but it is
an invalid IR transformation nonetheless, and similar
code in fgMorphSmpOpOptional guards against non-integral sources.
    @SingleAccretion
    SingleAccretion committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    94de26a View commit details
    Browse the repository at this point in the history