Expose missing references which are present in the runtime and in packages in the targeting pack #54147

ViktorHofer · 2021-06-14T15:03:52Z

The platform analyzers warns for usages of APIs which aren't available
on specific platforms. Exposing the missing reference assemblies which
are already part of the runtime pack in the targeting pack.

The big benefit of doing so is that customers don't need to reference
the corresponding packages to target these APIs and that these five
packages can be dead-ended.

Affected packages:

Microsoft.Win32.Registry
System.IO.FileSystem.AccessControl
System.IO.Pipes.AccessControl
System.Security.AccessControl
System.Security.Principal.Windows

For more in-depth reasoning, see the detailed summary:
#53892 (comment)

Update depents by referencing the latest available package. Making sure
that packages are never used on NetCoreAppCurrent by applying
.NETCoreApp version conditions.

Fixes #53892

I will send out a notice to the affected upstream repos windowsdesktop and aspnetcore after this is merged so that they can remove the references from their targeting packs. cc @dougbu @RussKie

ghost · 2021-06-14T15:04:00Z

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

The platform analyzers warns for usages of APIs which aren't available
on specific platforms. Exposing the missing reference assemblies which
are already part of the runtime pack in the targeting pack.

The big benefit of doing so is that customers don't need to reference
the corresponding packages to target these APIs and that these five
packages can be dead-ended.

For more in-depth reasoning, see the detailed summary:
#53892 (comment)

Update depents by referencing the latest available package. Making sure
that packages are never used on NetCoreAppCurrent by applying
.NETCoreApp version conditions.

Fixes #53892

Author:	ViktorHofer
Assignees:	ViktorHofer
Labels:	`area-Infrastructure-libraries`
Milestone:	6.0.0

ViktorHofer · 2021-06-14T15:09:02Z

...aries/System.Security.Cryptography.Xml/src/System/Security/Cryptography/Xml/CryptoHelpers.cs

@@ -22,7 +22,9 @@ name switch
                "urn:mpeg:mpeg21:2003:01-REL-R-NS:licenseTransform" => new XmlLicenseTransform(),
                "http://www.w3.org/2000/09/xmldsig# X509Data" => new KeyInfoX509Data(),
                "http://www.w3.org/2000/09/xmldsig# KeyName" => new KeyInfoName(),
+#pragma warning disable CA1416 // This call site is reachable on all platforms. 'DSAKeyValue' is unsupported on: 'ios', 'maccatalyst', 'tvos'


Started an offline thread with @buyaa-n @GrabYourPitchforks and @bartonjs to figure out what to do about this and the other exclusion in SignedXmlDebugLog.cs (change below).

dougbu · 2021-06-14T19:24:43Z

Affected packages:

Microsoft.Win32.Registry

System.IO.FileSystem.AccessControl;

System.IO.Pipes.AccessControl;

System.Security.AccessControl;

System.Security.Principal.Windows;

@ViktorHofer the Microsoft.AspNetCore.App.Ref package and our targeting packs contain Microsoft.Win32.Registry, System.Security.AccessControl, and System.Security.Principal.Windows. We also reference all but the System.Security.AccessControl package in a few projects.

To confirm: Once this is in and Maestro++ updates us to a build containing it,

We won't need the above three assemblies in our targeting packs❔
We shouldn't reference the same-named packages when targeting net6.0 or later❔

/cc @dotnet/aspnet-build

eng/Versions.props

safern · 2021-06-14T20:22:11Z

src/libraries/System.DirectoryServices/src/System.DirectoryServices.csproj

@@ -158,6 +160,7 @@
    <Reference Include="System.ComponentModel.TypeConverter" />
    <Reference Include="System.Diagnostics.Debug" />
    <Reference Include="System.IO.FileSystem" />
+    <Reference Include="System.IO.FileSystem.AccessControl" Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net6.0'))" />


Instead of adding this verbose condition to each item, can we group them in a shared itemgroup where the condition is set to the whole itemgroup?

These will go away in 4-5 months when we target NET7 so I don't care much about the added verbosity. Let's keep it as is meanwhile.

src/libraries/pkg/Microsoft.Windows.Compatibility/Microsoft.Windows.Compatibility.pkgproj

ViktorHofer · 2021-06-15T12:56:10Z

We won't need the above three assemblies in our targeting packs❔

Yes, the assemblies which are now part of the Microsoft.NETCore.App.Ref targeting pack shouldn't be exposed in aspnetcore's and windowsdesktop's targeting pack anymore.

We shouldn't reference the same-named packages when targeting net6.0 or later❔

Exactly. Conflict resolution will trim the reference assembly that comes from the package away anyway but removing the now unnecessary PackageReferences from project files reduces complexity and restore time.

The platform analyzers warns for usages of APIs which aren't available on specific platforms. Exposing the missing reference assemblies which are already part of the runtime pack in the targeting pack. The big benefit of doing so is that customers don't need to reference the corresponding packages to target these APIs and that these five packages can be dead-ended. For more in-depth reasoning, see the detailed summary: dotnet#53892 (comment) Fixes dotnet#53892

Update depents by referencing the latest available package. Making sure that packages are never used on NetCoreAppCurrent by applying .NETCoreApp version conditions.

src/libraries/System.Security.Cryptography.Xml/src/System.Security.Cryptography.Xml.csproj

safern · 2021-06-15T22:15:14Z

src/libraries/pkg/Microsoft.Windows.Compatibility/Microsoft.Windows.Compatibility.pkgproj

-    <Dependency Include="@(ExternalLibraryPackage)">
-      <TargetFramework>netstandard2.1</TargetFramework>
-    </Dependency>
+    <Dependency Include="@(ExternalLibraryPackage)"


Do net6.0 need ExternalLibraryPackage in it's dependency group?

safern

Other than one question, LGTM. Thank you :)

ericstj · 2021-06-16T16:09:34Z

Cool! @ryalanms @dougbu FYI you'll need to react to this in ASP.NET and WindowsDesktop shared frameworks.

ViktorHofer · 2021-06-16T16:10:57Z

@ericstj I contacted both here in the PR and via mail. We are following up offline.

- remove newly-unnecessary package references - do not expect affected assemblies in _our_ targeting packs

Relates to dotnet/runtime#54147 Relates to dotnet/windowsdesktop#1747

…/efcore (#33571) [release/6.0-preview6] Update dependencies from dotnet/runtime dotnet/efcore - React to dotnet/runtime#54147 - remove newly-unnecessary package references - do not expect affected assemblies in _our_ targeting packs - Add baseline suppression - !fixup! Suppress correct reference - Omit System.Security.Permissions. dotnet/runtime#54341 System.Security.Permissions is brought in by System.Security.Cryptography.Xml for netstandard2.0 compatibility but not required in net6.0 since the types required exist in System.Security.AccessControl - Permit PackageReferences from ref/runtime-pack - Fix Permissions version reference and delete dead packages - More dead package cleanup - Try again at transitioning dead-end package to 5.0 version - Fix up version of added package - Fix PackageReference from DataProtection -> Registry This was present in the previous release and shouldn't be removed since this is part of the public contract of the netstandard2.0 build of DataProtection. - Apply suggestions from code review Co-authored-by: Doug Bunting <6431421+dougbu@users.noreply.github.com> - Get System.Security.Permissions refs working - Update src/DataProtection/DataProtection/src/Microsoft.AspNetCore.DataProtection.csproj - Suppress all of System.Security.Permissions dependency closure - Add missing dependencies

[main] Update dependencies from dotnet/runtime dotnet/efcore - React to dotnet/runtime#54147 - remove newly-unnecessary package references - do not expect affected assemblies in _our_ targeting packs - Add baseline suppression - !fixup! Suppress correct reference - Manually align w/ #33571 - add excluded System.Security.Permissions references - stop auto-updating dead-ended packages - switch to 5.0.0 version of Microsoft.Win32.Registry - switch to 5.0.0 version of System.Security.Principal.Windows - Suppress all of System.Security.Permissions dependency closure - cherry-picked from #33571 - Add missing dependencies - cherry-picked from #33571

ViktorHofer added the area-Infrastructure-libraries label Jun 14, 2021

ViktorHofer added this to the 6.0.0 milestone Jun 14, 2021

ViktorHofer requested review from ericstj and Anipik June 14, 2021 15:03

ViktorHofer self-assigned this Jun 14, 2021

dotnet-issue-labeler bot added the new-api-needs-documentation label Jun 14, 2021

ViktorHofer changed the title ~~Add platform specifics to targeting pack~~ Expose missing references which are present in the runtime and in packages in the targeting pack Jun 14, 2021

ViktorHofer requested a review from safern June 14, 2021 15:08

ViktorHofer commented Jun 14, 2021

View reviewed changes

safern reviewed Jun 14, 2021

View reviewed changes

eng/Versions.props Outdated Show resolved Hide resolved

safern reviewed Jun 14, 2021

View reviewed changes

src/libraries/pkg/Microsoft.Windows.Compatibility/Microsoft.Windows.Compatibility.pkgproj Outdated Show resolved Hide resolved

ViktorHofer force-pushed the AddPlatformSpecificsToTargetingPack branch from e23b794 to 256ead6 Compare June 15, 2021 11:59

ViktorHofer removed the new-api-needs-documentation label Jun 15, 2021

dotnet deleted a comment from dotnet-issue-labeler bot Jun 15, 2021

ViktorHofer added 8 commits June 15, 2021 16:43

Update dependents of dead-ended packages

5288fe2

Update depents by referencing the latest available package. Making sure that packages are never used on NetCoreAppCurrent by applying .NETCoreApp version conditions.

Fixes

2d8a066

Remove pkg validation suppression file

4882f68

Update Windows Compatibility pack

781ca2a

Fix DirectoryServices pkg references

1de3134

Fix netfx Pkcs restore/build

721ed63

Fix version conflict

c549d96

ViktorHofer force-pushed the AddPlatformSpecificsToTargetingPack branch from dd31634 to c549d96 Compare June 15, 2021 14:46

ViktorHofer added 2 commits June 15, 2021 17:43

Packageindex and nits

27287f6

nits

fc8680d

akoeplinger approved these changes Jun 15, 2021

View reviewed changes

src/libraries/System.Security.Cryptography.Xml/src/System.Security.Cryptography.Xml.csproj Show resolved Hide resolved

ViktorHofer merged commit 663c40d into dotnet:main Jun 15, 2021

ViktorHofer deleted the AddPlatformSpecificsToTargetingPack branch June 15, 2021 17:32

safern reviewed Jun 15, 2021

View reviewed changes

dougbu added a commit to dotnet/aspnetcore that referenced this pull request Jun 16, 2021

React to dotnet/runtime#54147

c5ca81f

- remove newly-unnecessary package references - do not expect affected assemblies in _our_ targeting packs

dougbu added a commit to dotnet/aspnetcore that referenced this pull request Jun 16, 2021

React to dotnet/runtime#54147

7977dfb

- remove newly-unnecessary package references - do not expect affected assemblies in _our_ targeting packs

jeffhandley mentioned this pull request Jun 16, 2021

[main] Update dependencies from dotnet/runtime dotnet/sdk#18292

Merged

joeloff mentioned this pull request Jun 16, 2021

Address new analyzer warnings dotnet/sdk#18300

Open

danmoseley mentioned this pull request Jun 17, 2021

[release/6.0-preview6] Update dependencies from dotnet/winforms dotnet/wpf#4686

Merged

This was referenced Jun 17, 2021

Remove new Microsoft.NETCore.App.Ref targeting pack assemblies from WindowsDesktop targeting pack dotnet/windowsdesktop#1747

Merged

[main] Update dependencies from dotnet/wpf dotnet/windowsdesktop#1746

Merged

RussKie added a commit to RussKie/winforms that referenced this pull request Jun 18, 2021

Remove refs provided by Microsoft.NETCore.App.Ref targeting pack

1adbdce

Relates to dotnet/runtime#54147 Relates to dotnet/windowsdesktop#1747

RussKie mentioned this pull request Jun 18, 2021

Remove refs provided by Microsoft.NETCore.App.Ref targeting pack dotnet/winforms#5127

Merged

This was referenced Jun 21, 2021

[main] Update dependencies from dotnet/winforms dotnet/wpf#4697

Merged

Remove references now included in the Microsoft.NETCore.App.Ref targeting pack + update SDK dotnet/wpf#4706

Merged

ghost locked as resolved and limited conversation to collaborators Jul 16, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Expose missing references which are present in the runtime and in packages in the targeting pack #54147

Expose missing references which are present in the runtime and in packages in the targeting pack #54147

ViktorHofer commented Jun 14, 2021 •

edited

Loading

ghost commented Jun 14, 2021

ViktorHofer Jun 14, 2021 •

edited

Loading

dougbu commented Jun 14, 2021

safern Jun 14, 2021

ViktorHofer Jun 15, 2021

ViktorHofer commented Jun 15, 2021

safern Jun 15, 2021 •

edited

Loading

safern left a comment

ericstj commented Jun 16, 2021

ViktorHofer commented Jun 16, 2021

Expose missing references which are present in the runtime and in packages in the targeting pack #54147

Expose missing references which are present in the runtime and in packages in the targeting pack #54147

Conversation

ViktorHofer commented Jun 14, 2021 • edited Loading

ghost commented Jun 14, 2021

ViktorHofer Jun 14, 2021 • edited Loading

Choose a reason for hiding this comment

dougbu commented Jun 14, 2021

safern Jun 14, 2021

Choose a reason for hiding this comment

ViktorHofer Jun 15, 2021

Choose a reason for hiding this comment

ViktorHofer commented Jun 15, 2021

safern Jun 15, 2021 • edited Loading

Choose a reason for hiding this comment

safern left a comment

Choose a reason for hiding this comment

ericstj commented Jun 16, 2021

ViktorHofer commented Jun 16, 2021

ViktorHofer commented Jun 14, 2021 •

edited

Loading

ViktorHofer Jun 14, 2021 •

edited

Loading

safern Jun 15, 2021 •

edited

Loading