[WIP][wasm][testing] remote loop network tests via xharness and websocket #54289

pavelsavara · 2021-06-16T18:51:35Z

Make it possible to run `LoopbackServer` tests with WASM

via moving the listening socket out of WASM process into xharness process and forwarding it via WebSockets
Contributes to #42852

conditional compilation of LoopbackServer via #if TARGET_BROWSER
minimal implementation of WebSocketStream for the unit tests
simple SocketWrapper class to abstract Socket and WebSocket close/dispose/shutdown
added handling of CORS headers and pre-flight requests as necessary for browser HTTP client

xharness

new xharness web server middleware
adding it to helix payload

tests

93 tests enabled for WASM
better categorization of tests originally under Runtime developer can run Networking tests without Loopback server capability (on mobile/browser platforms) #42852, [mono] Tests failed on windows: System.Net.*.Tests #34690
new active issues [wasm][websocket] System.Net.WebSockets.Client.Tests should throw #54153, [wasm] Enable crypto and related tests #37669, [wasm] Trailer headers not implemented #54156, [wasm][http] System.Net.Http.Functional.Tests.HttpClientTest - Expected: System.Threading.Tasks.TaskCanceledException #54270, [wasm][http] System.Net.Http.Functional.Tests should throw HttpRequestException #54160, [wasm] HttpRequestMessage.Headers.ExpectContinue is ignored on browser #53876, [wasm][http] response.ReasonPhrase is wrong #54163 , [wasm][http] response.Content.ReadAsStreamAsync().CanSeek != false #54159 for pending problems

ghost · 2021-06-16T18:51:43Z

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Make it possible to run `LoopbackServer` tests with WASM

via moving the listening socket out of WASM process into xharness process and forwarding it via WebSockets

conditional compilation of LoopbackServer via #if TARGET_BROWSER
minimal implementation of WebSocketStream for the unit tests
simple SocketWrapper class to abstract Socket and WebSocket close/dispose/shutdown
added handlind of CORS headers and pre-flight requests as necessary

xharness

new xharness web server middleware
adding it to helix payload

tests

many tests enabled for WASM
better categorization of tests originally under 42852, 34690
new active issues 54153,37669,54156,54270,54160,53876,54163 for pending problems

Author:	pavelsavara
Assignees:	-
Labels:	`area-System.Net.Http`
Milestone:	-

pavelsavara · 2021-06-16T20:12:06Z

/azp run runtime

azure-pipelines · 2021-06-16T20:12:36Z

Azure Pipelines successfully started running 1 pipeline(s).

ghost · 2021-06-17T09:19:51Z

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Make it possible to run `LoopbackServer` tests with WASM

via moving the listening socket out of WASM process into xharness process and forwarding it via WebSockets

conditional compilation of LoopbackServer via #if TARGET_BROWSER
minimal implementation of WebSocketStream for the unit tests
simple SocketWrapper class to abstract Socket and WebSocket close/dispose/shutdown
added handlind of CORS headers and pre-flight requests as necessary for browser HTTP client

xharness

new xharness web server middleware
adding it to helix payload

tests

many tests enabled for WASM
better categorization of tests originally under Runtime developer can run Networking tests without Loopback server capability (on mobile/browser platforms) #42852, [mono] Tests failed on windows: System.Net.*.Tests #34690
new active issues [wasm][websocket] System.Net.WebSockets.Client.Tests should throw #54153, [wasm] Enable crypto and related tests #37669, [wasm] Trailer headers not implemented #54156, [wasm][http] System.Net.Http.Functional.Tests.HttpClientTest - Expected: System.Threading.Tasks.TaskCanceledException #54270, [wasm][http] System.Net.Http.Functional.Tests should throw HttpRequestException #54160, [wasm] HttpRequestMessage.Headers.ExpectContinue is ignored on browser #53876, [wasm][http] response.ReasonPhrase is wrong #54163 for pending problems

Author:	pavelsavara
Assignees:	-
Labels:	`arch-wasm`, `area-System.Net.Http`
Milestone:	-

pavelsavara · 2021-06-17T11:19:24Z

/azp run runtime-libraries-mono outerloop

azure-pipelines · 2021-06-17T11:19:36Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2021-06-17T15:26:14Z

/azp run runtime-libraries-mono outerloop

azure-pipelines · 2021-06-17T15:26:26Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2021-06-18T11:13:44Z

Failed System.Drawing.Common.Tests is Timeout. All the failed tests in mono outer loop are unrelated and pre-existing.

wfurt

Generally looks good to me.
I'm not sure I like the SocketWrapper name but I did not come up with anything better.
Long run we may add the CORS headers where needed to avoid fork for Browser.

cc: @dotnet/ncl @stephentoub for visibility.

src/libraries/Common/tests/System/Net/Configuration.Http.cs

ManickaP

Looks good, some minor comments, thanks.

src/libraries/Common/tests/System/Net/Configuration.Http.cs

src/libraries/Common/tests/System/Net/Http/GenericLoopbackServer.cs

src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.cs

src/libraries/Common/tests/System/Net/Http/LoopbackServer.cs

- conditional compilation of LoopbackServer via #if TARGET_BROWSER - minimal implementation of WebSocketStream for the unit tests - simple SocketWrapper class to abstract Socket and WebSocket close/dispose/shutdown - added handlind of CORS headers and pre-flight requests as necessary - new xharness web server middleware - adding it to helix payload - better categorization of tests originally under 42852, 34690 - new active issues 54153,37669,54156,54270,54160,53876,54163

radical

Just some nits, and questions. Nothing to block this over.

src/libraries/Common/tests/System/Net/Http/LoopbackServer.cs

...braries/Common/tests/System/Net/Prerequisites/RemoteLoopServer/Handlers/RemoteLoopHandler.cs

src/libraries/Common/tests/System/Net/Prerequisites/RemoteLoopServer/RemoteLoopServer.csproj

src/libraries/Common/tests/System/Net/WebSockets/WebSocketStream.cs

pavelsavara requested review from radical, lewing, ManickaP and wfurt June 16, 2021 18:51

dotnet-issue-labeler bot added the area-System.Net.Http label Jun 16, 2021

pavelsavara mentioned this pull request Jun 16, 2021

GetFunctionPointerForDelegateTests tests fail with Specified cast is not valid on Browser #39187

Open

pavelsavara added the arch-wasm WebAssembly architecture label Jun 17, 2021

pavelsavara mentioned this pull request Jun 17, 2021

[wasm][http] Make content stream unseekable #54303

Closed

pavelsavara mentioned this pull request Jun 17, 2021

Runtime developer can run Networking tests without Loopback server capability (on mobile/browser platforms) #42852

Closed

7 tasks

pavelsavara marked this pull request as ready for review June 17, 2021 14:18

wfurt approved these changes Jun 21, 2021

View reviewed changes

src/libraries/Common/tests/System/Net/Configuration.Http.cs Outdated Show resolved Hide resolved

ManickaP approved these changes Jun 21, 2021

View reviewed changes

pavelsavara added 8 commits June 21, 2021 16:23

fix

6b7acde

fix

c261265

fix

c018002

fix

d229620

feedback

bca373a

feedback

74dfcb4

feedback

42ad7fb

pavelsavara force-pushed the pr_wasm_network_test_remote_loop branch from c3bdadd to 42ad7fb Compare June 21, 2021 14:56

feedback

1b7b3fa

radical reviewed Jun 22, 2021

View reviewed changes

pavelsavara added 3 commits June 22, 2021 11:29

feedback

81ea0a4

feedback

0b58cd8

feedback

6b43f3c

pavelsavara merged commit fe89236 into dotnet:main Jun 22, 2021

karelz added this to the 6.0.0 milestone Jul 15, 2021

This was referenced Jul 28, 2021

System.Net.Security test run killed on Mono Linux #56478

Closed

[WinHttpHandler] Long running test: ResponseHeadersRead_SynchronizationContextNotUsedByHandler on Win7/Win8 #54034

Closed

pavelsavara deleted the pr_wasm_network_test_remote_loop branch July 29, 2021 08:48

karelz mentioned this pull request Aug 27, 2021

ExecutionContext_NotCachedInSocketAsyncEventArgs - failure in Assert.True #1722

Closed

ghost locked as resolved and limited conversation to collaborators Aug 28, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP][wasm][testing] remote loop network tests via xharness and websocket #54289

[WIP][wasm][testing] remote loop network tests via xharness and websocket #54289

pavelsavara commented Jun 16, 2021 •

edited

Loading

ghost commented Jun 16, 2021

Make it possible to run `LoopbackServer` tests with WASM

xharness

tests

pavelsavara commented Jun 16, 2021

azure-pipelines bot commented Jun 16, 2021

ghost commented Jun 17, 2021

Make it possible to run `LoopbackServer` tests with WASM

xharness

tests

pavelsavara commented Jun 17, 2021

azure-pipelines bot commented Jun 17, 2021

pavelsavara commented Jun 17, 2021

azure-pipelines bot commented Jun 17, 2021

pavelsavara commented Jun 18, 2021

wfurt left a comment

ManickaP left a comment

radical left a comment

[WIP][wasm][testing] remote loop network tests via xharness and websocket #54289

[WIP][wasm][testing] remote loop network tests via xharness and websocket #54289

Conversation

pavelsavara commented Jun 16, 2021 • edited Loading

Make it possible to run LoopbackServer tests with WASM

xharness

tests

ghost commented Jun 16, 2021

Make it possible to run LoopbackServer tests with WASM

xharness

tests

pavelsavara commented Jun 16, 2021

azure-pipelines bot commented Jun 16, 2021

ghost commented Jun 17, 2021

Make it possible to run LoopbackServer tests with WASM

xharness

tests

pavelsavara commented Jun 17, 2021

azure-pipelines bot commented Jun 17, 2021

pavelsavara commented Jun 17, 2021

azure-pipelines bot commented Jun 17, 2021

pavelsavara commented Jun 18, 2021

wfurt left a comment

Choose a reason for hiding this comment

ManickaP left a comment

Choose a reason for hiding this comment

radical left a comment

Choose a reason for hiding this comment

pavelsavara commented Jun 16, 2021 •

edited

Loading

Make it possible to run `LoopbackServer` tests with WASM

Make it possible to run `LoopbackServer` tests with WASM

Make it possible to run `LoopbackServer` tests with WASM