Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Update dependencies from 9 repositories #54543

Merged
merged 9 commits into from
Jun 25, 2021
Merged

[main] Update dependencies from 9 repositories #54543

merged 9 commits into from
Jun 25, 2021

Conversation

premun
Copy link
Member

@premun premun commented Jun 22, 2021

This is same as 04ad80a but we need to run the PR checks here

@dotnet-maestro @premun
[main] Update dependencies from 9 repositories (#54218)
5a588d0 
[main] Update dependencies from 9 repositories


 - Merge branch 'main' into darc-main-b0a81754-f267-416d-a8e2-cf56f8c1ee3e

 - PInvoke warnings fixes for OOB assemblies

 - Update testPackages.proj

 - Update testPackages.proj

 - Update dependencies from https://github.com/dotnet/arcade build 20210621.1

 - Merge branch 'main' into darc-main-b0a81754-f267-416d-a8e2-cf56f8c1ee3e

Conflicts:
	eng/Version.Details.xml
	eng/Versions.props

 - Fix xml

 - Update dependencies from https://github.com/dotnet/xharness build 20210622.2
@ghost
Copy link

ghost commented Jun 22, 2021

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

This is same as 04ad80a but we need to run the PR checks here

Author: premun
Assignees: -
Labels:

area-Infrastructure-libraries
Milestone: -

@premun premun requested a review from ViktorHofer June 22, 2021 11:24
@premun
Copy link
Member Author

premun commented Jun 22, 2021 •
edited
Loading

@ViktorHofer not sure if we should do this or just let Maestro handle it but then we would need to do the manual fixes again..

@ViktorHofer
Copy link
Member

@premun I think opening this PR manually is fine to get to a green state again. Last time I checked, there were a lot failures that I wasn't sure of why they were happening.

ViktorHofer
ViktorHofer approved these changes Jun 22, 2021
View reviewed changes
Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-approving but I expect more changes to be necessary.

@ViktorHofer
Copy link
Member

/azp run runtime

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ViktorHofer
Copy link
Member

@premun @akoeplinger @steveisok what are all these Browser and Android failures about??

@steveisok
Copy link
Member

They appear to be runtime test failures. @SamMonoRT may know more.

@SamMonoRT
Copy link
Member

@naricc @fanyang-mono are the failures in wasm and android lanes here known ?

@premun
Copy link
Member Author

premun commented Jun 23, 2021

@fanyang-mono the Android ones seem to be XHarness trying to run an app that wasn't installed before:
https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-54543-merge-d33e7953be674ec7bf/JIT/console.12c4ea14.log?sv=2019-07-07&se=2021-07-13T19%3A04%3A55Z&sr=c&sp=rl&sig=LHLZIFt4KSWxPGpSReQuCeqds6Vnfqotj4RcUE2ug00%3D

@premun
Copy link
Member Author

premun commented Jun 24, 2021

We found the issues in WASM with @pavelsavara. It is an XHarness regression, fix coming soon

@pavelsavara
Copy link
Member

dotnet/xharness#651

@premun premun mentioned this pull request Jun 24, 2021
Closed
@premun
Copy link
Member Author

premun commented Jun 24, 2021

One more fix - dotnet/xharness#652

@fanyang-mono fanyang-mono mentioned this pull request Jun 24, 2021
Merged
@ViktorHofer
Copy link
Member

I'm seeing similar restore issues in other PRs as well...

@premun
Copy link
Member Author

premun commented Jun 24, 2021

@ViktorHofer the previous run in this PR was almost all green. What was failing were Android and WASM things and I think I have fixed those now so we care about the runtime tests on wasm browser, I think.

But the other failures I have seen were out of my scope, so maybe if you can have a look at this build and tell?
https://dev.azure.com/dnceng/public/_build/results?buildId=1203690&view=results
(minus the WASM issues)

@lewing
Copy link
Member

lewing commented Jun 24, 2021

#53899 added WaitForNextTickAsync_CanceledWaitThenWaitAgain_Succeeds which is one of the failures

@GrabYourPitchforks GrabYourPitchforks mentioned this pull request Jun 24, 2021
Merged
@premun
Copy link
Member Author

premun commented Jun 25, 2021

Merging as WaitForNextTickAsync_CanceledWaitThenWaitAgain_Succeeds is known and it's the only failure

@premun premun merged commit 419506b into main Jun 25, 2021
@premun premun deleted the prvysoky/dependencies branch June 25, 2021 07:07
@runfoapp runfoapp bot mentioned this pull request Jun 25, 2021
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Jul 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fanyang-mono fanyang-mono fanyang-mono left review comments

@ViktorHofer ViktorHofer ViktorHofer approved these changes

Assignees
No one assigned
Labels
area-Infrastructure-libraries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@premun @ViktorHofer @steveisok @SamMonoRT @pavelsavara @lewing @fanyang-mono