Improve performance of IsRootScope check

[davidfowl]

• Stash a field instead of doing an equality comparison.

Fixes #54351

PS: I'm not sure how to run those performance tests.

[ghost]

Tagging subscribers to this area: @eerhardt, @maryamariyan
See info in area-owners.md if you want to be subscribed.

Issue Details

---

• Stash a field instead of doing an equality comparison.

Fixes #54351

PS: I'm not sure how to run those performance tests.

Author:	davidfowl
Assignees:	-
Labels:	area-Extensions-DependencyInjection
Milestone:	-

[pakrym]

Fixes #54351

Optimistic :)

[eerhardt]

PS: I'm not sure how to run those performance tests.

There is a Repro section in the issue #54351

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f netcoreapp5.0 --filter 'Microsoft.Extensions.DependencyInjection.GetService*'

[davidfowl]

python3 wtf. Is there an easy way to run on the same hardware? Also do I need to manually patch bits and run before and after?

[eerhardt]

python3 wtf.

+💯

Is there an easy way to run on the same hardware? Also do I need to manually patch bits and run before and after?

cc @DrewScoggins @billwert

[billwert]

What's wrong with python? :)

If you have two runtimes you want to run back to back, I recommend running benchmarks_ci.py once to bootstrap everything and then you can follow the directions here:
https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md#preventing-regressions

Snapshot your baseline, then you can iterate as necessary with the after build.

[davidfowl]

OR I could just merge it.

[billwert]

Sure. We'll see the impact in the system soon enough if you do.

[ghost]

Hello @davidfowl!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.