Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add non-LLVM iOS size scenario #54585

Merged
merged 5 commits into from
Jun 24, 2021
Merged

Add non-LLVM iOS size scenario #54585

merged 5 commits into from
Jun 24, 2021

Conversation

billwert
Copy link
Member

No description provided.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@billwert
Copy link
Member Author

I'm doing a full CI run one more time to make sure everything is good since the merge was a bit annoying, but this is ready for review.

</PropertyGroup>

<ItemGroup>
<HelixWorkItem Include="SOD - iOS HelloWorld .app Size - LLVM=False">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should have the LLVM configuration set in the configuration field. This would allow for us to compare these tests across configs much easier.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SamMonoRT Why no LLVM?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@steveisok and @billwert are trying to figure out a blocker from our side using LLVM. Goal is to measure both, but got this stood up to make it easier. We will want to compare both.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the blocker is down to #54572

@DrewScoggins
Copy link
Member

It shouldn't be part of this commit, but I wonder if we can do fewer builds to cut down on our AzDO resource use

@billwert
Copy link
Member Author

@DrewScoggins this is ready now.

Copy link
Member

@DrewScoggins DrewScoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@billwert billwert merged commit 1c81556 into dotnet:main Jun 24, 2021
@billwert billwert deleted the add-ios branch June 24, 2021 17:46
@ghost ghost locked as resolved and limited conversation to collaborators Jul 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants