-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add non-LLVM iOS size scenario #54585
Conversation
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
I'm doing a full CI run one more time to make sure everything is good since the merge was a bit annoying, but this is ready for review. |
</PropertyGroup> | ||
|
||
<ItemGroup> | ||
<HelixWorkItem Include="SOD - iOS HelloWorld .app Size - LLVM=False"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should have the LLVM configuration set in the configuration field. This would allow for us to compare these tests across configs much easier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SamMonoRT Why no LLVM?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@steveisok and @billwert are trying to figure out a blocker from our side using LLVM. Goal is to measure both, but got this stood up to make it easier. We will want to compare both.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the blocker is down to #54572
It shouldn't be part of this commit, but I wonder if we can do fewer builds to cut down on our AzDO resource use |
@DrewScoggins this is ready now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.