Resolve ILLink warnings in Microsoft.Extensions.Hosting #55048
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried a couple different approaches here, but settled on the current iteration. The drawback of the current iteration is that if new code is added to this class, we are suppressing
IL2091
even for the new code.Alternative 1: Manually write the closures
eerhardt@f8e1199
I didn't like this approach because it is way too much manual code for one line, and the compiler has features to do this for us. It is replacing 1 line of code with 40.
Alternative 2: Use assembly level suppression with Scope/Target and only suppressing the individual warnings
This doesn't work - it suppresses the warnings for the whole assembly. I logged dotnet/linker#2127.
When that issue is fixed in the linker, we can convert this suppression over to that approach.