Handle incomplete writes #55474
Closed
Handle incomplete writes #55474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-system-io Issue DetailsThis is a short term solution for #55473. It solves the problem, but only for I can't provide a better solution right now because I am on vacations. I'll be back in a week, then I can provide a long-term fix.
|
filipnavara
reviewed
Jul 11, 2021
| Span<byte> buffer = bytes; | ||
| do | ||
| { | ||
| int bytesWritten = RandomAccess.WriteAtOffset(sfh, buffer, offset); |
There was a problem hiding this comment.
Should this somehow handle !buffer.IsEmpty && bytesWritten == 0 to prevent infinite loop? (Logically, it would make more sense to me as a while loop instead of do-while loop).
| #pragma warning restore CA2012 | ||
|
|
||
| private ValueTask<int> WriteAsyncCore(ReadOnlyMemory<byte> source, CancellationToken cancellationToken) | ||
| public override ValueTask WriteAsync(ReadOnlyMemory<byte> source, CancellationToken cancellationToken) |
There was a problem hiding this comment.
Suggested change
| public override ValueTask WriteAsync(ReadOnlyMemory<byte> source, CancellationToken cancellationToken) | |
| public override async ValueTask WriteAsync(ReadOnlyMemory<byte> source, CancellationToken cancellationToken) |
|
Thanks. #55490 provides the longer-term fix. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a short term solution for #55473. It solves the problem, but only for
FileStreamand it's introducing a performance regression (allocations).I can't provide a better solution right now because I am on vacations. I'll be back in a week, then I can provide a long-term fix.