Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Update dependencies from mono/linker #55813

Merged
merged 6 commits into from
Jul 21, 2021
Merged

[main] Update dependencies from mono/linker #55813

merged 6 commits into from
Jul 21, 2021

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jul 16, 2021 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/mono/linker

  • Subscription: 0d6d6ae4-f71f-4395-53e6-08d8e409d87d
  • Build: 20210719.3
  • Date Produced: 7/19/2021 5:17 PM
  • Commit: 8d49e169d872d6225bcf73ae14ae50b002f39319
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/mono/linker build 20210715.1
18efaa0 
Microsoft.NET.ILLink.Tasks
 From Version 6.0.100-preview.6.21362.3 -> To Version 6.0.100-preview.6.21365.1
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@dotnet-maestro
Update dependencies from https://github.com/mono/linker build 20210716.2
14accf0 
Microsoft.NET.ILLink.Tasks
 From Version 6.0.100-preview.6.21362.3 -> To Version 6.0.100-preview.6.21366.2
@marek-safar
Copy link
Contributor

@tlakollo possible RUC regression or libraries changes are needed

/cc @vitek-karas @eerhardt

@vitek-karas
Copy link
Member

@sbomer

This is basically caused by dotnet/linker#2148. We could workaround it by adding suppressions on the affected types.

But the real fix is waiting on dotnet/linker#2136 - which will introduce a new warning code and ability to suppress it on-method - that will require libraries changes (suppressions).

@sbomer
Copy link
Member

sbomer commented Jul 19, 2021

In case we want to get dependency flow unblocked, these runtime changes should work: sbomer@3f9ebc5. But we'll need to update them again as soon as that issue is fixed, so I'd rather wait for the real fix.

@eerhardt
Copy link
Member

How far out is the "real fix"? If it is more than a day or two, I'd prefer we unblock the dependency flow.

@sbomer
Suppress type hierarchy warnings
f5088c8 
Suppress type hierarchy warnings for
DynamicallyAccessedMembers attribute on types that
have members with RequiresUnreferencedCode (or derived
types with such members).
@sbomer
Copy link
Member

sbomer commented Jul 19, 2021

Hopefully just a day or two, but I pushed my changes so we don't have to wait - PTAL.

sbomer and others added 3 commits July 19, 2021 21:29
@sbomer
Feedback
e5ba222 
Remove unnecessary local method
@sbomer
Fix typo
d239831
@dotnet-maestro
Update dependencies from https://github.com/mono/linker build 20210719.3
a317a25 
Microsoft.NET.ILLink.Tasks
 From Version 6.0.100-preview.6.21362.3 -> To Version 6.0.100-preview.6.21369.3
agocke
agocke approved these changes Jul 21, 2021
View reviewed changes
Copy link
Member

@agocke agocke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agocke agocke merged commit aaba3c2 into main Jul 21, 2021
@agocke agocke deleted the darc-main-cdbb2965-b4a4-4d50-bd41-afca83bdae32 branch July 21, 2021 01:07
@agocke
Copy link
Member

agocke commented Jul 21, 2021

/backport to release/6.0-preview7

@github-actions
Copy link
Contributor

Started backporting to release/6.0-preview7: https://github.com/dotnet/runtime/actions/runs/1053678159

@github-actions github-actions bot mentioned this pull request Jul 21, 2021
Closed
@karelz karelz mentioned this pull request Jul 28, 2021
Closed
@danmoseley danmoseley added the area-codeflow for labeling automated codeflow label Jul 28, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eerhardt eerhardt eerhardt left review comments

@agocke agocke agocke approved these changes

@vitek-karas vitek-karas Awaiting requested review from vitek-karas

Assignees
No one assigned
Labels
area-codeflow for labeling automated codeflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@marek-safar @vitek-karas @sbomer @eerhardt @agocke @danmoseley