-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm][debugger] Fix step behavior #55915
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tagging subscribers to this area: @thaystg Issue DetailsCreating test to close #49143.
|
thaystg
changed the title
[wasm][]debugger] Creating test to evaluate ToString()
[wasm][debugger] Creating test to evaluate ToString()
Jul 19, 2021
thaystg
changed the title
[wasm][debugger] Creating test to evaluate ToString()
[wasm][debugger] Fix step over behavior
Jul 19, 2021
…ng debugger-libs+mono or coreclr. Fix error message of evaluate calling methods. Adding test for dotnet#49142
thaystg
changed the title
[wasm][debugger] Fix step over behavior
[wasm][debugger] Fix step behavior
Jul 19, 2021
radical
reviewed
Jul 19, 2021
radical
reviewed
Jul 19, 2021
radical
reviewed
Jul 19, 2021
radical
reviewed
Jul 19, 2021
radical
reviewed
Jul 19, 2021
radical
reviewed
Jul 19, 2021
radical
approved these changes
Jul 20, 2021
This was referenced Jul 28, 2021
ghost
locked as resolved and limited conversation to collaborators
Aug 20, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The case that we would get a different behavior is when we have more than one command being executed in the same line:
var d = TimeSpan.TryParseExact(y, @"ss\.fff", null, out var ts) && x.Contains('S');
When we step over we stop in the same line again, then we need to step over again to go to next line.
NOTE: If we want to backport it to preview7 we also need to backport #55869, otherwise it will break step after hotreload for wasm.