Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm][debugger] Fix step behavior #55915

Merged
merged 6 commits into from
Jul 21, 2021
Merged

Conversation

thaystg
Copy link
Member

@thaystg thaystg commented Jul 19, 2021

The case that we would get a different behavior is when we have more than one command being executed in the same line:
var d = TimeSpan.TryParseExact(y, @"ss\.fff", null, out var ts) && x.Contains('S');
When we step over we stop in the same line again, then we need to step over again to go to next line.

NOTE: If we want to backport it to preview7 we also need to backport #55869, otherwise it will break step after hotreload for wasm.

@ghost
Copy link

ghost commented Jul 19, 2021

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

Creating test to close #49143.

Author: thaystg
Assignees: -
Labels:

area-Debugger-mono

Milestone: -

@thaystg thaystg changed the title [wasm][]debugger] Creating test to evaluate ToString() [wasm][debugger] Creating test to evaluate ToString() Jul 19, 2021
@thaystg thaystg marked this pull request as draft July 19, 2021 13:34
@thaystg thaystg changed the title [wasm][debugger] Creating test to evaluate ToString() [wasm][debugger] Fix step over behavior Jul 19, 2021
…ng debugger-libs+mono or coreclr.

Fix error message of evaluate calling methods.
Adding test for dotnet#49142
@thaystg thaystg marked this pull request as ready for review July 19, 2021 17:14
@thaystg thaystg requested a review from radical July 19, 2021 17:14
@thaystg thaystg changed the title [wasm][debugger] Fix step over behavior [wasm][debugger] Fix step behavior Jul 19, 2021
@thaystg thaystg merged commit f85f579 into dotnet:main Jul 21, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants