Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update analyzer rulesets #55925

Merged
merged 1 commit into from
Jul 20, 2021
Merged

Conversation

stephentoub
Copy link
Member

No description provided.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

eng/CodeAnalysis.ruleset Outdated Show resolved Hide resolved
@stephentoub stephentoub merged commit 4e405a1 into dotnet:main Jul 20, 2021
@stephentoub stephentoub deleted the updateanalyzerlists branch July 20, 2021 02:44
@xtqqczze
Copy link
Contributor

xtqqczze commented Jul 20, 2021

@stephentoub Should CA2252 be in Microsoft.CodeAnalysis.NetAnalyzers, I'm not seeing it in 6.0.0-rc1.21366.3.

@stephentoub
Copy link
Member Author

Should CA2252 be in Microsoft.CodeAnalysis.NetAnalyzers

Yes, it's correct.

I'm not seeing it in 6.0.0-rc1.21366.3

This repo is currently using:

<MicrosoftCodeAnalysisNetAnalyzersVersion>6.0.0-rc1.21366.2</MicrosoftCodeAnalysisNetAnalyzersVersion>

and it's there:
image

@pgovind
Copy link

pgovind commented Jul 20, 2021

So I was speaking to the analyzer repo folks and was informed that the DetectPreviewFeatureAnalyzer failed to flow to the sdk's P7 branch because of a transient Nuget failure. dotnet/sdk#19084 just popped up. With that PR, I assume the analyzer will flow to the P7 branch, and we then risk subsequent P7 branch runtime builds failing (not sure how the dependencies flow after the sdk is updated)? I wonder if we should be safe here and backport this PR just in case? (I'll start a backport in the interest of time and we can close it if we think it's unnecessary)

/backport to release/6.0-preview7

@github-actions
Copy link
Contributor

Started backporting to release/6.0-preview7: https://github.com/dotnet/runtime/actions/runs/1050204778

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants