-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update analyzer rulesets #55925
Update analyzer rulesets #55925
Conversation
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
78cee23
to
82a9cf2
Compare
82a9cf2
to
4c86676
Compare
@stephentoub Should CA2252 be in |
Yes, it's correct.
This repo is currently using: Line 53 in f100379
and it's there: |
So I was speaking to the analyzer repo folks and was informed that the DetectPreviewFeatureAnalyzer failed to flow to the sdk's P7 branch because of a transient Nuget failure. dotnet/sdk#19084 just popped up. With that PR, I assume the analyzer will flow to the P7 branch, and we then risk subsequent P7 branch runtime builds failing (not sure how the dependencies flow after the sdk is updated)? I wonder if we should be safe here and backport this PR just in case? (I'll start a backport in the interest of time and we can close it if we think it's unnecessary) /backport to release/6.0-preview7 |
Started backporting to release/6.0-preview7: https://github.com/dotnet/runtime/actions/runs/1050204778 |
No description provided.