-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display class names and string literals in asm #55970
Conversation
@dotnet/jit-contrib PTAL |
I did similar thing for arm64 |
How will this work with SuperPMI? Do we already make the necessary queries when not generating ASM/JitDump, so when replaying we'll get this improved output? If not, can the appropriate queries be added under |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. Added some comments.
Co-authored-by: Kunal Pathak <Kunal.Pathak@microsoft.com>
@BruceForstall works fine locally, zero diffs. I guess all these |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
@BruceForstall PTAL (PR is currently blocked on your change request). |
Merging to Main. It only affects debug/checked builds. |
Just a little change to display class names and string literals in the asm, e.g.:
xarch for now (slightly more verbose changes to enable it for arm)
GDV emits class handles a lot so it's quite useful to be able to see actual types in asm without DUMPs.