Upgrade to msbuild version 16.10 to fix big-endian bug

[uweigand]

• Fixes Microsoft.NETCore.Platforms.Tests uses MSBuild version with big-endian bug #54826

• Adjust net472 dependencies of Microsoft.NETCore.Platforms.Tests

[ghost]

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

---

• Fixes Microsoft.NETCore.Platforms.Tests uses MSBuild version with big-endian bug #54826

• Adjust net472 dependencies of Microsoft.NETCore.Platforms.Tests

Author:	uweigand
Assignees:	-
Labels:	area-Infrastructure-libraries
Milestone:	-

[ericstj]

Actually, I might have signed off too soon. Looks like this property is shared across many projects and is meant to be RefOnly I think rather than change this we should add a reference in the test to a non-RefOnly version.

[ericstj]

Looking through the history, I made a significant change here 75206ed#diff-1ea18ff65faa2ae6fed570b83747086d0317f5e4bc325064f6c14319a9c4ff67R142 and @radical made a change here: 0416c34#diff-1ea18ff65faa2ae6fed570b83747086d0317f5e4bc325064f6c14319a9c4ff67R143.

I think we're OK bumping this. MSBuild doesn't change the assembly version in their packages, so by updating our references the worst we do is expose MSBuild API to consuming projects that may not be present in a version of MSBuild they wish to run in.

In the future it might make sense to add a DARC subscription from MSBuild -> runtime for test purposes that we use in test projects for tasks.

[uweigand]

Edit: Sorry -- I missed your update immediately above before adding this comment!

Actually, I might have signed off too soon. Looks like this property is shared across many projects and is meant to be RefOnly I think rather than change this we should add a reference in the test to a non-RefOnly version.

Is there a reason why we cannot just upgrade that version everywhere? It was upgraded from 16.8 to 16.9 only a month ago, shouldn't it track recent releases anyway?

If we do have create a special version for this package, I guess this would mean updating this block in src/libraries/Microsoft.NETCore.Platforms/src/Microsoft.NETCore.Platforms.csproj:

  <ItemGroup>
    <PackageReference Include="Microsoft.Build" Version="$(RefOnlyMicrosoftBuildVersion)" />
    <PackageReference Include="Microsoft.Build.Tasks.Core" Version="$(RefOnlyMicrosoftBuildTasksCoreVersion)" />
    <PackageReference Include="NuGet.ProjectModel" Version="$(RefOnlyNugetProjectModelVersion)" />
  </ItemGroup>

using a new property (or multiple) in eng/Versions.props, right? I haven't added a new propery to that file before, are there any specific concerns about naming etc.? I see some comments about automatic updates, not sure if this has to be taken into consideration.

[ericstj]

Networking failures are #56295 and #55957