Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Eliminate backtracking in the interpreter for patterns with .… #56034

Closed
wants to merge 1 commit into from

Conversation

pgovind
Copy link
Contributor

@pgovind pgovind commented Jul 20, 2021

…* (#51508)"

This reverts commit 7eb749c.

cc @BrennanConroy @danmoseley @jeffhandley @tannergooding

I'll add the regression as a unit test in a separate PR and investigate a fix locally (will probably only target .NET7P1 at this point for the optimization changes)

@ghost
Copy link

ghost commented Jul 20, 2021

Tagging subscribers to this area: @eerhardt, @dotnet/area-system-text-regularexpressions
See info in area-owners.md if you want to be subscribed.

Issue Details

…* (#51508)"

This reverts commit 7eb749c.

I'll add the regression as a unit test in a separate PR and investigate a fix locally. Will probably only target .NET7P1 at this point

Author: pgovind
Assignees: -
Labels:

area-System.Text.RegularExpressions

Milestone: -

@pgovind pgovind requested a review from stephentoub July 20, 2021 19:06
@stephentoub
Copy link
Member

#56031 is 37 minutes ahead ;-)

@pgovind
Copy link
Contributor Author

pgovind commented Jul 20, 2021

#56031 is 37 minutes ahead ;-)

Ah, I wasn't tagged on there, so I never got the notification for it. Thanks. I'll close this

@pgovind pgovind closed this Jul 20, 2021
@stephentoub
Copy link
Member

I wasn't tagged on there, so I never got the notification for it

Oh, interesting. Do you not get notifications when area-System.Text.RegularExpressions is added to something or when @dotnet/area-system-text-regularexpressions is tagged? I'm wondering if we have a broader issue to be fixed.

@pgovind
Copy link
Contributor Author

pgovind commented Jul 20, 2021

Do you not get notifications when area-System.Text.RegularExpressions

My bad, I was wrong. I do get the notifications for area-System.Text.RegularExpressions. I did get this notification too. It came in right after the P7 one you had open, and the titles were the same, so I assumed all of them were related to the P7 PR :)

@stephentoub
Copy link
Member

Ok, cool :-)

@ghost ghost locked as resolved and limited conversation to collaborators Aug 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants