Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add timeout handling to QuicStream #56060

Merged
merged 7 commits into from
Aug 11, 2021
Merged

add timeout handling to QuicStream #56060

merged 7 commits into from
Aug 11, 2021

Conversation

wfurt
Copy link
Member

@wfurt wfurt commented Jul 20, 2021

I know this is low priority but I did it as experiment while working on #55642 to at least prevent infinite hang.
I did not want to loose so we may turn it into deaf and wait.
The scope and risk is small IMHO as it mimics what NetworkStream does.
The behavior is covered by conformance tests that would light up on CanTimeout

@wfurt wfurt requested a review from a team July 20, 2021 23:41
@wfurt wfurt self-assigned this Jul 20, 2021
@ghost
Copy link

ghost commented Jul 20, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

I know this is low priority but I did it as experiment while working on #55642 to at least prevent infinite hang.
I did not want to loose so we may turn it into deaf and wait.
The scope and risk is small IMHO as it mimics what NetworkStream does.
The behavior is covered by conformance tests that would light up on CanTimeout

Author: wfurt
Assignees: wfurt
Labels:

area-System.Net.Quic

Milestone: -

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@geoffkizer
Copy link
Contributor

I think it's fine to merge this if it helps track down test issues, but let's make sure we aren't introducing any new complications. From what I can see the code seems pretty isolated, so hopefully we aren't.

Copy link
Member

@CarnaViire CarnaViire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wfurt wfurt merged commit a33dbf3 into dotnet:main Aug 11, 2021
@wfurt wfurt deleted the quicTimeout2 branch August 11, 2021 04:09
@karelz karelz added this to the 6.0.0 milestone Aug 17, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Sep 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants