Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert the last crossgen tests to use crossgen2 #56061

Merged
merged 1 commit into from
Jul 21, 2021
Merged

Convert the last crossgen tests to use crossgen2 #56061

merged 1 commit into from
Jul 21, 2021

Conversation

davidwrighton
Copy link
Member

  • take advantage of the AlwaysUseCrossGen2 flag instead of manually updating all the crossgen commands
  • remove version bubbles test. We have much more complex testing for that scenario now
  • remove regular crossgen logic from the script generator

Fixes #743

@davidwrighton
Convert the last crossgen tests to use crossgen2
86837c8 
- take advantage of the AlwaysUseCrossGen2 flag instead of manually updating all the crossgen commands
- remove version bubbles test. We have much more complex testing for that scenario now
- remove regular crossgen logic from the script generator
@davidwrighton
Copy link
Member Author

@dotnet/crossgen-contrib

trylek
trylek approved these changes Jul 21, 2021
View reviewed changes
Copy link
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup, thanks David!

@trylek trylek merged commit 415356f into dotnet:main Jul 21, 2021
@BruceForstall BruceForstall mentioned this pull request Jul 28, 2021
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Aug 20, 2021
@davidwrighton davidwrighton deleted the convert_last_crossgen_tests branch April 13, 2023 18:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trylek trylek trylek approved these changes

@mangod9 mangod9 mangod9 approved these changes

Assignees
No one assigned
Labels
area-crossgen2-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix all tests under test\src\readytorun to work with the crossgen2 run
3 participants
@davidwrighton @trylek @mangod9