Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove disabled tests that depend on the verifier #56118

Merged

Conversation

BruceForstall
Copy link
Member

The verifier is not supported in .NET Core.

Fixes #5812

The verifier is not supported in .NET Core.

Fixes dotnet#5812
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jul 22, 2021
@BruceForstall
Copy link
Member Author

@jkotas Can you think of any reason we should keep these verifier tests?

@dotnet/jit-contrib PTAL

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I do not see a good reason for keeping these tests.

@BruceForstall BruceForstall merged commit 136be33 into dotnet:main Jul 22, 2021
@BruceForstall BruceForstall deleted the DeleteTestsRequiringVerification branch July 22, 2021 05:23
@ghost ghost locked as resolved and limited conversation to collaborators Aug 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failures due to no Verifier support in .NET Core
2 participants