Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explicit dependency on System.Reflection.Metadata to RuntimeConfigParser task #56152

Merged
merged 5 commits into from
Jul 23, 2021
Merged

Add explicit dependency on System.Reflection.Metadata to RuntimeConfigParser task #56152

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ad7a002
Add explicit dep on SRM to MonoTargets.
directhex Jul 22, 2021
1f889c6
Guard dependency so it's not there on net6
directhex Jul 22, 2021
ba9f665
Changes suggested by @steveisok
directhex Jul 22, 2021
ee37dc4
Merge remote-tracking branch 'origin/main' into srm-dependency
directhex Jul 22, 2021
b2cf297
Merge remote-tracking branch 'origin/main' into srm-dependency
directhex Jul 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/tasks/RuntimeConfigParser/RuntimeConfigParser.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,12 @@
<PackageReference Include="Microsoft.Build.Framework" Version="$(RefOnlyMicrosoftBuildFrameworkVersion)" />
<PackageReference Include="Microsoft.Build.Tasks.Core" Version="$(RefOnlyMicrosoftBuildTasksCoreVersion)" />
<PackageReference Include="Microsoft.Build.Utilities.Core" Version="$(RefOnlyMicrosoftBuildUtilitiesCoreVersion)" />
<PackageReference Include="System.Reflection.Metadata" Version="5.0.0" />
</ItemGroup>
<ItemGroup Condition="'$(TargetFramework)' == '$(TargetFrameworkForNETCoreTasks)'">
<PackageReference Include="System.Reflection.Metadata" Version="$(SystemReflectionMetadataVersion)" />
</ItemGroup>
<ItemGroup Condition="'$(TargetFramework)' == '$(TargetFrameworkForNETFrameworkTasks)'">
<PackageReference Include="System.Reflection.Metadata" Version="$(SystemReflectionMetadataVersion)" PrivateAssets="All" />
</ItemGroup>
<ItemGroup>
<Compile Include="RuntimeConfigParser.cs" />
Expand All @@ -26,7 +31,7 @@
<_PublishFramework Remove="@(_PublishFramework)" />
<_PublishFramework Include="$(TargetFrameworks)" />

<FilesToPackage Include="$(OutputPath)%(_PublishFramework.Identity)\$(AssemblyName).dll" TargetPath="tasks\%(_PublishFramework.Identity)" />
<FilesToPackage Include="$(OutputPath)%(_PublishFramework.Identity)\*.dll" TargetPath="tasks\%(_PublishFramework.Identity)" />
</ItemGroup>
</Target>

Expand Down