Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: XmlWriterSettings.Encoding must be registered in static Encoding #56164

Merged
merged 2 commits into from
Jul 23, 2021
Merged

Fix: XmlWriterSettings.Encoding must be registered in static Encoding #56164

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85392cd
Fix: XmlWriterSettings.Encoding must be registered in static Encoding
krwq Jul 22, 2021
f143a60
Update src/libraries/System.Private.Xml/src/System/Xml/Core/XmlEncode…
krwq Jul 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions src/libraries/System.Private.Xml/src/System/Xml/Core/XmlEncodedRawTextWriter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,11 +160,8 @@ public XmlEncodedRawTextWriter(Stream stream, XmlWriterSettings settings) : this
// grab bom before possibly changing encoding settings
ReadOnlySpan<byte> bom = _encoding.Preamble;

// the encoding instance this creates can differ from the one passed in
this._encoding = Encoding.GetEncoding(
settings.Encoding.CodePage,
_charEntityFallback,
settings.Encoding.DecoderFallback);
_encoding = (Encoding)settings.Encoding.Clone();
_encoding.EncoderFallback = _charEntityFallback;

_encoder = _encoding.GetEncoder();

Expand Down