Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report that allocations may have side effects for all types outside of the version bubble #56177

Merged
merged 2 commits into from
Jul 26, 2021
Merged

Report that allocations may have side effects for all types outside of the version bubble #56177

merged 2 commits into from
Jul 26, 2021

Conversation

davidwrighton
Copy link
Member

Fixes #45628

@davidwrighton
Copy link
Member Author

@dotnet/crossgen-contrib

trylek
trylek approved these changes Jul 22, 2021
View reviewed changes
Copy link
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me and I believe that the linker test failure is unrelated to your change.

@davidwrighton davidwrighton merged commit a336536 into dotnet:main Jul 26, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 25, 2021
@davidwrighton davidwrighton deleted the fix_45628 branch April 13, 2023 18:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trylek trylek trylek approved these changes

Assignees
No one assigned
Labels
area-crossgen2-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

getNewHelper hasSideEffects return value not correctly handling R2R versioning
2 participants
@davidwrighton @trylek