Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove crossgen comparison jobs #56193

Merged
merged 1 commit into from
Jul 26, 2021
Merged

Remove crossgen comparison jobs #56193

merged 1 commit into from
Jul 26, 2021

Conversation

davidwrighton
Copy link
Member

  • We no longer have crossgen
  • The jobs didn't detect that failure and have been wasting CPU time on every PR

@davidwrighton
Remove crossgen comparison jobs
9844a12 
- We no longer have crossgen
- The jobs didn't detect that failure and have been wasting CPU time on every PR
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@mangod9
Copy link
Member

mangod9 commented Jul 23, 2021

yeah interesting why these didnt start failing when crossgen was removed? What was being compared in the job ?

@davidwrighton
Copy link
Member Author

It was testing the output after running the script, so, it really was just spinning wheels. It didn't check that the crossgen commands succeeded.

trylek
trylek approved these changes Jul 23, 2021
View reviewed changes
Copy link
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thanks for cleaning this up!

@davidwrighton davidwrighton merged commit 6168c4a into dotnet:main Jul 26, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 25, 2021
@davidwrighton davidwrighton deleted the remove_useless_crossgen_comparision_jobs branch April 13, 2023 18:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trylek trylek trylek approved these changes

@mangod9 mangod9 mangod9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidwrighton @mangod9 @trylek