Fix createdump crash on alpine 3.12 and above. #56272
Conversation
Finally hit an existing problem in createdump (since 2.1) where the std::set<MemoryRegions> in ThreadInfo::GetThreadStack() where it is calling CrashInfo::SearchMemoryRegions with m_crashInfo.OtherMappings() which returns a copy of the set of MemoryRegions instead of a reference. On alpine 3.12 musl, this set copy is freed right away when it goes out of scope as soon as SearchMemoryRegions returns. On any other Linux distro and MacOS the set doesn't get freed/invalidated as soon. Return references to the threads and memory region sets in the CrashInfo functions.
|
Tagging subscribers to this area: @tommcdon Issue DetailsFinally hit an existing problem in createdump (since 2.1) where the std::set in Return references to the threads and memory region sets in the CrashInfo functions.
|
| pClrDataProcess->QueryInterface(__uuidof(ISOSDacInterface), (void**)&pSos); | ||
|
|
||
| if (pClrDataProcess != nullptr) { | ||
| pClrDataProcess->QueryInterface(__uuidof(ISOSDacInterface), (void**)&pSos); |
There was a problem hiding this comment.
I wonder if this logic should be inside the UnwindThread. We already always do a null check in there and we only use this interface in case there's an exception. This is pretty cheap, so I don't mind it.
There was a problem hiding this comment.
I'll clean that up next time.
ghost
locked as resolved and limited conversation to collaborators
Finally hit an existing problem in createdump (since 2.1) where the std::set in
ThreadInfo::GetThreadStack() where it is calling CrashInfo::SearchMemoryRegions with m_crashInfo.OtherMappings()
which returns a copy of the set of MemoryRegions instead of a reference. On alpine 3.12 musl, this set copy
is freed right away when it goes out of scope as soon as SearchMemoryRegions returns. On any other Linux distro
and MacOS the set doesn't get freed/invalidated as soon.
Return references to the threads and memory region sets in the CrashInfo functions.