Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0-preview7] Specify win-x64 as a valid platform in the microsoft-net-runtime-* workloads for iOS/tvOS/MacCatalyst #56312

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jul 26, 2021

Backport of #56311 to release/6.0-preview7

/cc @steveisok

Customer Impact

In order to isolate installing iOS/tvOS/MacCatalyst runtime packs on windows, we created a separate workload runtimes-*. That workload had win-x64 as part of the platforms entry, but the workloads maui references did not.

Testing

Tested microsoft-net-runtime-* installs properly on Windows

Risk

Very low

…rkloads for iOS/tvOS/MacCatalyst

In a prior change, win-x64 was specified for runtimes-*, but it is also needed in the other workloads
@ghost
Copy link

ghost commented Jul 26, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #56311 to release/6.0-preview7

/cc @steveisok

Customer Impact

Testing

Risk

Author: github-actions[bot]
Assignees: -
Labels:

area-System.Net

Milestone: -

@steveisok steveisok requested review from Anipik and lewing July 26, 2021 15:36
@steveisok steveisok added the Servicing-approved Approved for servicing release label Jul 26, 2021
@steveisok
Copy link
Member

Part of the installer changes and has been pre-approved.

@mmitche mmitche merged commit 64453dd into release/6.0-preview7 Jul 26, 2021
@lewing lewing deleted the backport/pr-56311-to-release/6.0-preview7 branch July 26, 2021 22:53
@karelz karelz added this to the 6.0.0 milestone Jul 29, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Net Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants