[release/6.0-preview7] Fix an error printed out when install_location file is missing #56330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
The app will still run, but we must not print out anything in that case.
|
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov Issue DetailsBackport of #56327 to release/6.0-preview7 /cc @agocke @vitek-karas Customer ImpactTestingRisk
|
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
agocke
force-pushed
the
backport/pr-56327-to-release/6.0-preview7
branch
from
7c21753
to
67ebe2b
Compare
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Jul 28, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #56327 to release/6.0-preview7
/cc @agocke @vitek-karas
Customer Impact
The changes for multi-arch caused what should be a COREHOST_TRACE diagnostic to be output as an error to stderr instead of being silent as normal.
The other app behavior does not change, but many people scrape the output of their app, and the extra text will break them.
This only occurs when using the apphost, which mostly isn’t used in CI.
Testing
Unit tests
Risk
Low. Changes only a call to the error helper.