Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0-preview7] Update dependencies from dotnet/arcade #56358

Conversation

dotnet-maestro[bot]
Copy link
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: 449fc7bd-f1b1-4109-5ad9-08d93c09849a
  • Build: 20210723.11
  • Date Produced: 7/24/2021 12:29 AM
  • Commit: c6a28c81f96d196338b3ea520bc1e6dc7c440ee2
  • Branch: refs/heads/main
  • Updates to .NET SDKs:
    • Updates sdk.version to 6.0.100-preview.6.21355.2
    • Updates tools.dotnet to 6.0.100-preview.6.21355.2

…723.11

Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.GenFacades , Microsoft.DotNet.GenAPI , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SharedFramework.Sdk
 From Version 6.0.0-beta.21372.16 -> To Version 6.0.0-beta.21373.11
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@lukas-lansky
Copy link
Contributor

resource ILLink.Substitutions.xml in System.Net.Http, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a(7,8): error IL2009: Could not find method 'System.Boolean get_IsNativeHandlerEnabled()' on type 'System.Net.Http.HttpClientHandler' [/__w/1/s/src/libraries/System.Net.WebClient/tests/System.Net.WebClient.Tests.csproj]
##[error]resource ILLink.Substitutions.xml in System.Net.Http, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a(7,8): error IL2009: (NETCORE_ENGINEERING_TELEMETRY=Build) Could not find method 'System.Boolean get_IsNativeHandlerEnabled()' on type 'System.Net.Http.HttpClientHandler'
resource ILLink.Substitutions.xml in System.Net.Http, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a(7,8): error IL2009: Could not find method 'System.Boolean get_IsNativeHandlerEnabled()' on type 'System.Net.Http.HttpClientHandler' [/__w/1/s/src/libraries/System.Net.HttpListener/tests/System.Net.HttpListener.Tests.csproj]
##[error]resource ILLink.Substitutions.xml in System.Net.Http, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a(7,8): error IL2009: (NETCORE_ENGINEERING_TELEMETRY=Build) Could not find method 'System.Boolean get_IsNativeHandlerEnabled()' on type 'System.Net.Http.HttpClientHandler'

Maybe related to upgrade of SDK from 6.0.100-preview.4.21255.9 to 6.0.100-preview.6.21355.2? @dotnet/runtime-infrastructure?

@akoeplinger
Copy link
Member

akoeplinger commented Jul 27, 2021

Yeah it's caused by the P6 SDK update, it was fixed in main with 2b3f76c, we'd need to backport to preview7 if we want to take this arcade update.

It was discovered in #56161 that mobile specific HttpClientHandler substitutions were sticking around even for non mobile builds. This change moves the substitution into ILLink.Substitutions.mobile.xml.
@akoeplinger
Copy link
Member

Hm actually I think this won't be enough since we're running into other issues with the bump in #56211 (comment).

I think we should not take this PR for the preview7 branch.

@lukas-lansky
Copy link
Contributor

Yeah, makes sense @akoeplinger. Thanks!

Closing, @mmitche please re-open if you think we want this.

@akoeplinger akoeplinger deleted the darc-release/6.0-preview7-02aec587-6fd1-4b74-954f-7a3a087b154a branch July 27, 2021 13:51
@danmoseley danmoseley added the area-codeflow for labeling automated codeflow label Jul 28, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-codeflow for labeling automated codeflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants