Skip finalizer test if precise GC is not supported #56364
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test assumes the
AsyncOperation
object created inNotCompleted
is collected by theGC.Collect()
call. That is not guaranteed with the current Mono GC, which conservatively scans the whole stack. If a pointer to that object is still visible anywhere on that stack (or in any register, as the stack also contains register context save areas at the timeGC.Collect()
executes), the object may erroneously still be considered live.Whether or not the test actually fails depends on accidental details of the generated code; the test used to pass on s390x but after some unrelated codegen changes (enabling the linears optimization in Mono), it now fails.
Simply make the test depend on
IsPreciseGcSupported
, like many similar tests already are.