Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two issues with budget smoothing: #56467

Merged
merged 1 commit into from
Jul 29, 2021

Conversation

PeterSolMS
Copy link
Contributor

  • We smoothed budgets across LOH and POH by mistake
  • We didn't do any budget smoothing for LOH and POH in background GCs.

We currently do budget smoothing for gen 0, LOH and POH - we do not do smoothing for gen 1 and gen 2. There is probably no good reason why we don't.

- We smoothed budgets *across* LOH and POH by mistake
- We didn't do any budget smoothing for LOH and POH in background GCs.
@ghost
Copy link

ghost commented Jul 28, 2021

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

Issue Details
  • We smoothed budgets across LOH and POH by mistake
  • We didn't do any budget smoothing for LOH and POH in background GCs.

We currently do budget smoothing for gen 0, LOH and POH - we do not do smoothing for gen 1 and gen 2. There is probably no good reason why we don't.

Author: PeterSolMS
Assignees: -
Labels:

area-GC-coreclr

Milestone: -

Copy link
Member

@Maoni0 Maoni0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@PeterSolMS PeterSolMS merged commit d86299e into dotnet:main Jul 29, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants