Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an assert in PoolingAsyncValueTaskMethodBuilder #56468

Merged
merged 1 commit into from
Jul 28, 2021
Merged

Fix an assert in PoolingAsyncValueTaskMethodBuilder #56468

merged 1 commit into from
Jul 28, 2021

Conversation

stephentoub
Copy link
Member

Fixes #56459 (hopefully)

@ghost
Copy link

ghost commented Jul 28, 2021

Tagging subscribers to this area: @dotnet/area-system-threading-tasks
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #56459 (hopefully)

Author: stephentoub
Assignees: -
Labels:

area-System.Threading.Tasks
Milestone: -

adamsitnik
adamsitnik approved these changes Jul 28, 2021
View reviewed changes
Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for a very quick fix @stephentoub !

@adamsitnik adamsitnik added this to the 6.0.0 milestone Jul 28, 2021
@stephentoub stephentoub merged commit f5a7304 into dotnet:main Jul 28, 2021
@stephentoub stephentoub deleted the fixassert branch July 28, 2021 18:23
@ghost ghost locked as resolved and limited conversation to collaborators Aug 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adamsitnik adamsitnik adamsitnik approved these changes

Assignees
No one assigned
Labels
area-System.Threading.Tasks
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

Assertion failed in PoolingAsyncValueTaskMethodBuilderT
2 participants
@stephentoub @adamsitnik