Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify JIT shutdown logic in crossgen2 #56687

Merged
merged 1 commit into from
Aug 3, 2021
Merged

Simplify JIT shutdown logic in crossgen2 #56687

merged 1 commit into from
Aug 3, 2021

Commits on Aug 1, 2021

  1. Simplify JIT shutdown logic in crossgen2 

    There was unanswered comment about thread safety in https://github.com/dotnet/runtime/pull/56187/files#r675461236 so I just decided to fix it myself.

While on it, I simplified shutdown to use `AppDomain.ProcessExit`.

I'm not sure `AppDomain.UnhandledException` is needed but the original code had this in a `finally`.

The better fix would be to allow JIT to be initialized right before we start a compilation and shut down after, but that would require no process wide state in the JIT. As it stands now, JIT is once-per-process-global.
    @MichalStrehovsky
    MichalStrehovsky committed Aug 1, 2021
    Configuration menu
    Copy the full SHA
    c65fe44 View commit details
    Browse the repository at this point in the history