-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement DefType.IsUnsafeValueType #56790
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wish we could introduce the new property on MetadataType instead of DefType, but we don't have a place to cache things on MetadataType. Thanks!
src/coreclr/tools/Common/TypeSystem/Common/MetadataFieldLayoutAlgorithm.cs
Outdated
Show resolved
Hide resolved
src/coreclr/tools/Common/TypeSystem/Common/MetadataFieldLayoutAlgorithm.cs
Outdated
Show resolved
Hide resolved
src/coreclr/tools/Common/TypeSystem/Common/MetadataFieldLayoutAlgorithm.cs
Outdated
Show resolved
Hide resolved
/azp run runtime-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
f8e385f
to
2c2d996
Compare
I rebased to make sure I picked up #56889. /azp run runtime-coreclr outerloop |
/azp run runtime-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
The failures look to be preexisting. |
I ran into a test failure while working on #56669 because we did an unexpected tailcall. In the test (TailcallVerifyWithPrefix
TailcallVerify.Condition17.Test1
) we expect not to do a fast tailcall because there is an unsafe value type and we expect to do a GS cookie check before exit, but because of this TODO we didn't.cc @dotnet/crossgen-contrib