-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generic math: Don't include System.Runtime reference assembly when publishing #57071
generic math: Don't include System.Runtime reference assembly when publishing #57071
Conversation
Fixes build failures on WebAssembly, ios and Android Fixes dotnet#55823 Fixes dotnet#55767
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Tagging subscribers to this area: @dotnet/area-system-runtime Issue DetailsSystem.Runtime.Experimental.csproj builds a reference assembly called
|
This reverts commit b1aa171. There is a gsharedvt error: ``` [19:59:19] fail: console.error: RuntimeError: function signature mismatch [19:59:19] fail: console.error: RuntimeError: function signature mismatch [19:59:19] fail: at System_Runtime_Experimental_Tests_System_Tests_UIntPtrTests_GenericMath_CreateSaturatingFromInt32Test (<anonymous>:wasm-function[13094]:0x43dcac) [19:59:19] fail: at corlib_aot_wrapper_gsharedvt_out_sig_pinvoke_void_ (<anonymous>:wasm-function[33266]:0xaa1d49) ```
The WASM AOT tests are still failing like this:
|
System.Runtime.Experimental.csproj builds a reference assembly called
System.Runtime.dll
that should be used when compiling, but should not be included when packaging. For normal out of tree projects this happens because the System.Runtime.Experimental.nupkg makes it evident that<PackageReference Include="System.RuntimeExperimental" />
only provides reference assembly assets. But in-tree for<ProjectReference>
we have to be explicit.Fixes #55823
Fixes #55767
Fixes #56836