Add linux mariner to rolling builds for libraries tests

[safern]

Fixes: #54478

[ghost]

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Fixes: #54478

Author:	safern
Assignees:	-
Labels:	area-Infrastructure-libraries
Milestone:	-

[safern]

Sample build including this queue here: https://dev.azure.com/dnceng/public/_build/results?buildId=1291084&view=results

[safern]

@bartonjs it seems like this crypto test is failing on Linux Mariner:

runtime/src/libraries/System.Security.Cryptography.Algorithms/tests/ChaCha20Poly1305Tests.cs

Line 441 in 57bfe47

public static void CheckIsSupported()

I guess OpenSsl is present but for some reason the runtime property is returning false, what is your advise? Just disable it for this distro?

[danmoseley]

Thanks

[bartonjs]

what is your advise? Just disable it for this distro?

Seems like a reasonable starting place. OpenSSL on Mariner must be built with one or both of nopoly1305 or nochacha. When things get more complicated we'll need to figure out how to better determine that in the tests (hopefully via a route other than just duplicating the product logic).

            else if (PlatformDetection.IsAndroid)
            {
                // Android with API Level 28 is the minimum API Level support for ChaChaPoly1305.
                expectedIsSupported = OperatingSystem.IsAndroidVersionAtLeast(28);
            }
+           else if (PlatformDetection.IsMariner)
+           {
+               // OpenSSL is present, and a high enough version,
+               // but the distro build options turned off ChaCha/Poly.
+           }
            else if (PlatformDetection.OpenSslPresentOnSystem &&
                (PlatformDetection.IsOSX || PlatformDetection.IsOpenSslSupported))
            {

Or something like that.

[danmoseley]

I wonder whether there's some assert we can add in the tests so that if Mariner changes its configuration, we can enable the tests again.

A minor thing though -- seems completely reasonable as stated above.

[bartonjs]

I wonder whether there's some assert we can add in the tests so that if Mariner changes its configuration, we can enable the tests again.

Well, the diff I proposed would leave Mariner running the test, but in the "expect: false" case, then the test would fail with "actual: true" and we'd be in what I called "when things get more complicated". So we already have that assert/action-signal 😄.

For this feature, the mainline tests only run when the platform says it's supported, this particular test just checks that the platform says things are (or aren't) supported as we expect them to be.

[safern]

Sounds good, I'll adjust accordingly.

[safern]

Done. New build with the changes: https://dev.azure.com/dnceng/public/_build/results?buildId=1292670&view=results

[safern]

Looks like some tests are failing on Mono. I will open issues and disable them.

cc: @steveisok @akoeplinger

[safern]

New rolling build: https://dev.azure.com/dnceng/public/_build/results?buildId=1296468&view=results

[safern]

The linux mariner build is now green. Merging as failures are unrelated.