-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Group 4] Enable nullable annotations for Microsoft.Extensions.Configuration.EnvironmentVariables
#57433
[Group 4] Enable nullable annotations for Microsoft.Extensions.Configuration.EnvironmentVariables
#57433
Conversation
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
Tagging subscribers to this area: @maryamariyan, @safern Issue DetailsNotes:
|
Microsoft.Extensions.Configuration.EnvironmentVariables
# Conflicts: # src/libraries/Microsoft.Extensions.Configuration.Abstractions/ref/Microsoft.Extensions.Configuration.Abstractions.csproj # src/libraries/Microsoft.Extensions.Configuration.Abstractions/src/Microsoft.Extensions.Configuration.Abstractions.csproj # src/libraries/Microsoft.Extensions.Configuration.EnvironmentVariables/ref/Microsoft.Extensions.Configuration.EnvironmentVariables.csproj # src/libraries/Microsoft.Extensions.Configuration.EnvironmentVariables/src/Microsoft.Extensions.Configuration.EnvironmentVariables.csproj # src/libraries/Microsoft.Extensions.Configuration/ref/Microsoft.Extensions.Configuration.csproj # src/libraries/Microsoft.Extensions.Configuration/src/Microsoft.Extensions.Configuration.csproj
…ion-EnvironmentVariables
- Add necessary TFMs - Make configureSource action nullable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the contribution here, @maxkoshevoi.
I pushed 2 changes:
- Merge with main
- Adding the necessary TFMs + one tweak to the
AddEnvironmentVariables(builder, action)
API to make the action nullable.
Will merge when the CI is green.
/azp run runtime |
Azure Pipelines successfully started running 1 pipeline(s). |
wasm failure is #61749. |
Related to #43605, #54012
Annotated according to:
Microsoft.Extensions.Configuration
#57414